Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Mon 3316 default contactgroup ldap import #7220

Merged
merged 10 commits into from
Mar 7, 2019

Conversation

sc979
Copy link
Contributor

@sc979 sc979 commented Feb 25, 2019

LDAP enhancements

Adding a default contactgroup

Adding a field in the LDAP parameters form to specify a default contactgroup.
Users manually added using the IHM, or users added from the login screen (using the auto-import from LDAP feature), will be added to the default contactgroup.
Useful to quickly add many users from many different ADs.

  • QA Team (Quality Assurance) with tests.
    Specify ACLs for a specific contactgroup
    Define this contactgroup as default in Parameters > LDAP > yourLdapConfiguration
    Manually add a user from the import menu.
    Log in using this user.
    The user should be added to the contactgroup and the ACL applied to this contactgroup should be applied to this user too.

  • reviewers to understand what are the stakes of the pull request.
    Check the QA Team description.
    More of it, the code was cleaned from :
    1- disabled features or dead features (like the list/form radio button in the import list; or replaced ON/OFF radio buttons in the LDAP form, but still present in the template).
    2- fetchRow() methods were replaced by fetch().
    3- punctuation was added to the translations files.
    4- a new text was added for the tooltip description and translated for the french version.
    5- some code's comments were translated in english.
    6- some queries were modified using bindValue method.

Fixes # (issue) : None

Type of change

  • New functionality (non-breaking change)

Target serie

  • 18.10.x
  • 19.04.x (master)

How this pull request can be tested ?

Specify ACLs for a specific contactgroup
Define this contactgroup as default in Parameters > LDAP > yourLdapConfiguration
Manually add a user from the import menu.
Log in using this user.
The user should be added to the contactgroup and the ACL applied to this contactgroup should be applied to this user too.

Checklist

Community contributors & Centreon team
  • I followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  •  I have rebased my development branch on the base branch (master, maintenance).
  • I have updated the release note in dedicated temporary section *
Centreon team only
  • I have made sure that the unit tests related to the story are successful.
  • I have made sure that unit tests covers 80% of the code written for the story.
  • I have made sure that acceptance tests related to the story are successful (local and CI)

@sc979 sc979 force-pushed the MON-3316-default-contactgroup-ldap-import branch from 214c197 to 08ea8c6 Compare February 26, 2019 09:02
www/class/centreonAuth.LDAP.class.php Outdated Show resolved Hide resolved
doc/en/administration_guide/parameters.rst Outdated Show resolved Hide resolved
www/class/centreonAuth.LDAP.class.php Outdated Show resolved Hide resolved
www/class/centreonLDAP.class.php Outdated Show resolved Hide resolved
www/class/centreonLDAP.class.php Outdated Show resolved Hide resolved
www/class/centreonLDAP.class.php Outdated Show resolved Hide resolved
www/class/centreonLDAP.class.php Show resolved Hide resolved
www/include/Administration/parameters/ldap/form.php Outdated Show resolved Hide resolved
www/include/Administration/parameters/ldap/form.php Outdated Show resolved Hide resolved
@sc979 sc979 force-pushed the MON-3316-default-contactgroup-ldap-import branch 2 times, most recently from 062befd to b192e81 Compare February 27, 2019 10:09
@chgautier chgautier force-pushed the MON-3316-default-contactgroup-ldap-import branch from b192e81 to 46e4ac0 Compare March 6, 2019 14:38
@sc979 sc979 merged commit 5e8f587 into 18.10.x Mar 7, 2019
sc979 added a commit that referenced this pull request Mar 7, 2019
* enh(UI): adding default user's contactgroup in LDAP form and cleaning code
@sc979 sc979 deleted the MON-3316-default-contactgroup-ldap-import branch March 7, 2019 15:00
vhr pushed a commit that referenced this pull request Mar 13, 2019
* enh(UI): adding default user's contactgroup in LDAP form and cleaning code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants