This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 240
Mon 3316 default contactgroup ldap import #7220
Merged
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc979
force-pushed
the
MON-3316-default-contactgroup-ldap-import
branch
from
February 26, 2019 09:02
214c197
to
08ea8c6
Compare
Nohzoh
suggested changes
Feb 26, 2019
agelibert
reviewed
Feb 26, 2019
sc979
force-pushed
the
MON-3316-default-contactgroup-ldap-import
branch
2 times, most recently
from
February 27, 2019 10:09
062befd
to
b192e81
Compare
Nohzoh
approved these changes
Feb 27, 2019
kduret
approved these changes
Mar 5, 2019
chgautier
force-pushed
the
MON-3316-default-contactgroup-ldap-import
branch
from
March 6, 2019 14:38
b192e81
to
46e4ac0
Compare
sc979
added a commit
that referenced
this pull request
Mar 7, 2019
* enh(UI): adding default user's contactgroup in LDAP form and cleaning code
vhr
pushed a commit
that referenced
this pull request
Mar 13, 2019
* enh(UI): adding default user's contactgroup in LDAP form and cleaning code
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
LDAP enhancements
Adding a default contactgroup
Adding a field in the LDAP parameters form to specify a default contactgroup.
Users manually added using the IHM, or users added from the login screen (using the auto-import from LDAP feature), will be added to the default contactgroup.
Useful to quickly add many users from many different ADs.
QA Team (Quality Assurance) with tests.
Specify ACLs for a specific contactgroup
Define this contactgroup as default in Parameters > LDAP > yourLdapConfiguration
Manually add a user from the import menu.
Log in using this user.
The user should be added to the contactgroup and the ACL applied to this contactgroup should be applied to this user too.
reviewers to understand what are the stakes of the pull request.
Check the QA Team description.
More of it, the code was cleaned from :
1- disabled features or dead features (like the list/form radio button in the import list; or replaced ON/OFF radio buttons in the LDAP form, but still present in the template).
2- fetchRow() methods were replaced by fetch().
3- punctuation was added to the translations files.
4- a new text was added for the tooltip description and translated for the french version.
5- some code's comments were translated in english.
6- some queries were modified using bindValue method.
Fixes # (issue) : None
Type of change
Target serie
How this pull request can be tested ?
Specify ACLs for a specific contactgroup
Define this contactgroup as default in Parameters > LDAP > yourLdapConfiguration
Manually add a user from the import menu.
Log in using this user.
The user should be added to the contactgroup and the ACL applied to this contactgroup should be applied to this user too.
Checklist
Community contributors & Centreon team
Centreon team only