Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Mon 3317 clapi ack #7187

Merged
merged 11 commits into from
Feb 26, 2019
Merged

Mon 3317 clapi ack #7187

merged 11 commits into from
Feb 26, 2019

Conversation

loiclau
Copy link
Contributor

@loiclau loiclau commented Feb 13, 2019

No description provided.

doc/en/api/clapi/objects/realtime_acknowledgement.rst Outdated Show resolved Hide resolved
doc/en/api/clapi/objects/realtime_acknowledgement.rst Outdated Show resolved Hide resolved
doc/en/api/clapi/objects/realtime_acknowledgement.rst Outdated Show resolved Hide resolved
doc/en/api/clapi/objects/realtime_acknowledgement.rst Outdated Show resolved Hide resolved
doc/en/api/clapi/objects/realtime_acknowledgement.rst Outdated Show resolved Hide resolved
doc/fr/api/clapi/objects/realtime_acknowledgement.rst Outdated Show resolved Hide resolved
doc/fr/api/clapi/objects/realtime_acknowledgement.rst Outdated Show resolved Hide resolved
lib/Centreon/Object/Acknowledgement/RtAcknowledgement.php Outdated Show resolved Hide resolved
lib/Centreon/Object/Acknowledgement/RtAcknowledgement.php Outdated Show resolved Hide resolved
doc/en/api/clapi/objects/realtime_acknowledgement.rst Outdated Show resolved Hide resolved
@adr-mo
Copy link
Contributor

adr-mo commented Feb 14, 2019

As discussed during latest meeting on PR, new classes, functions and so on... should be documented in the code. Currently it is resumed by the "automatic" create header of the IDE. Please enhance them by adding more "relevant" information. Thanks

@adr-mo adr-mo force-pushed the MON-3317-clapi-ack branch from 56284d0 to 81f5d55 Compare February 20, 2019 15:01
@adr-mo adr-mo changed the base branch from master to 18.10.x February 20, 2019 15:33
@adr-mo adr-mo changed the base branch from 18.10.x to master February 20, 2019 15:35
@adr-mo adr-mo force-pushed the MON-3317-clapi-ack branch from 76ca7c6 to 81f5d55 Compare February 20, 2019 15:39
@adr-mo
Copy link
Contributor

adr-mo commented Feb 20, 2019

I have created an other branch to validate on the 18.10.x MON-3317-clapi-ack-18-10-x
But the code can be cherry-picked so it should not be an issue at all at the end.

@loiclau loiclau merged commit 4c276a7 into master Feb 26, 2019
@loiclau loiclau deleted the MON-3317-clapi-ack branch February 26, 2019 13:02
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants