This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(CLAPI): check for "Reach API *" fields in user instead of "Reach … #7117
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
…Centreon Front-end" when using CLAPI - remove check for "contact_oreon" field - remove check for "contact_admin" field - add check whether at least on of reach_api/reach_api_rt field is active - fix warning in user form
victorvassilev
approved these changes
Jan 9, 2019
kduret
suggested changes
Jan 9, 2019
| if ($result === false) { | ||
| $isRemote = false; | ||
| } else { | ||
| $isRemote = array_map("myDecode", $DBRESULT->fetchRow()); |
There was a problem hiding this comment.
$DBRESULT->fetchRow() will always return false, isn't it ?
Cause it is already called previously and I guess there is only one value for isRemote
|
I think you change the clapi comportment, for me you just need to keep the delete of the query condition 'AND contact_oreon = '1''. |
kduret
approved these changes
Jan 10, 2019
loiclau
approved these changes
Jan 10, 2019
centreon-bot
pushed a commit
that referenced
this pull request
Jan 16, 2019
#7117) * fix(CLAPI): check for "Reach API *" fields in user instead of "Reach Centreon Front-end" when using CLAPI - remove check for "contact_oreon" field - remove check for "contact_admin" field - add check whether at least on of reach_api/reach_api_rt field is active - fix warning in user form * fix(typo): do not use fetchRow() twice * fix(clapi): change check for permissions from reach_api* fields to contact_admin * fix(enh): move closeCursor() outside of "if" condition
vhr
pushed a commit
that referenced
this pull request
Jan 23, 2019
#7117) * fix(CLAPI): check for "Reach API *" fields in user instead of "Reach Centreon Front-end" when using CLAPI - remove check for "contact_oreon" field - remove check for "contact_admin" field - add check whether at least on of reach_api/reach_api_rt field is active - fix warning in user form * fix(typo): do not use fetchRow() twice * fix(clapi): change check for permissions from reach_api* fields to contact_admin * fix(enh): move closeCursor() outside of "if" condition
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
…Centreon Front-end" when using CLAPI