Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

MON-3298 enhance utf-8 check #7072

Merged
merged 1 commit into from
Jan 25, 2019

Conversation

Nohzoh
Copy link
Contributor

@Nohzoh Nohzoh commented Dec 19, 2018

UTF-8 encoding control use lot of memory and engine conf generation fails when there are few thousands of resources
we'd better use the default php implementation instead (mb_detect_encoding)

@Nohzoh Nohzoh changed the title enhance utf-8 check MON-3298 enhance utf-8 check Dec 20, 2018
UTF-8 encoding control use lot of memory so the implementation is
replaced by the php default implementation (mb_detect_encoding)
@Nohzoh Nohzoh force-pushed the engine_conf_generation_memory_consumption branch from 889e576 to e6aff13 Compare January 24, 2019 16:22
@thiuyendang
Copy link
Contributor

thiuyendang commented Jan 25, 2019

Validated with rpms 1548423274.e6aff13a0.el7.
Configured 122 hosts and 1707 services including some with special characters
Before fix : error reproduced
After fix, no more error only with default value of the memory limit in php.ini file (128M)

@Nohzoh Nohzoh merged commit 7de10be into master Jan 25, 2019
@ganoze ganoze deleted the engine_conf_generation_memory_consumption branch January 28, 2019 14:51
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants