This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Mon 3281 set default language to browser #7046
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kduret
suggested changes
Dec 12, 2018
sc979
force-pushed
the
MON-3281-set-default-language-to-browser
branch
from
c293104 to
371e483
Compare
kduret
approved these changes
Dec 12, 2018
sc979
force-pushed
the
MON-3281-set-default-language-to-browser
branch
2 times, most recently
from
54e487f to
53a6905
Compare
callapa
suggested changes
Jan 3, 2019
sc979
force-pushed
the
MON-3281-set-default-language-to-browser
branch
from
ebefe89 to
1982ba3
Compare
callapa
approved these changes
Jan 3, 2019
sc979
force-pushed
the
MON-3281-set-default-language-to-browser
branch
from
1982ba3 to
6a1dd52
Compare
kduret
approved these changes
Jan 3, 2019
| $path = __DIR__ . "/../../include/common/javascript/datepicker/"; | ||
|
|
||
| // check if the fullLocale library exist | ||
| $datepickerFileToFound = "datepicker-" . substr($data, 0, 5) . ".js"; |
There was a problem hiding this comment.
I think you could use preg_match to avoid double substr
sc979
force-pushed
the
MON-3281-set-default-language-to-browser
branch
from
6a1dd52 to
3babed5
Compare
vhr
pushed a commit
that referenced
this pull request
Jan 23, 2019
* fix(DP): avoid datepicker error when language is set to null * fix(lang): replace default language value from 'NULL' to 'browser' * enh(DP): supporting more localizations
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve : MON-3281