This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(conf): protect hostname resolver from XSS #7043
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Resolve MON-3228
vhr
requested review from
miteto,
callapa,
lpinsivy,
leoncx,
kduret,
victorvassilev and
sc979
kduret
reviewed
Dec 12, 2018
| array('<', '>'), | ||
| $_GET['hostName'] | ||
| ); | ||
| echo gethostbyname($hostName); |
There was a problem hiding this comment.
should not be better echo htmlentities(gethostbyname($hostName)); ?
There was a problem hiding this comment.
If we do that the result will be:
I propose to strip the tags and remove all chars that are not compatible with the hostname.
kduret
approved these changes
Dec 12, 2018
sc979
approved these changes
Dec 14, 2018
Resolve MON-3228
|
QA validationfailed :'( |
kduret
approved these changes
Jan 3, 2019
sc979
approved these changes
Jan 3, 2019
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve MON-3228