This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(admin): add SQL and XSS protection of Administration Logs page #7038
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc979
approved these changes
Dec 11, 2018
kduret
suggested changes
Dec 11, 2018
| @@ -85,7 +85,9 @@ function searchUserName($user_name) | |||
| $contactList = array(); | |||
| $DBRES = $pearDB->query("SELECT contact_id, contact_name, contact_alias FROM contact"); | |||
| while ($row = $DBRES->fetchRow()) { | |||
| $contactList[$row["contact_id"]] = $row["contact_name"] . " (".$row["contact_alias"].")"; | |||
| $contactList[$row["contact_id"]] = CentreonUtils::escapeSecure( | |||
| $row["contact_name"] . " (".$row["contact_alias"].")" | |||
| @@ -188,10 +190,13 @@ function searchUserName($user_name) | |||
| } else { | |||
| $query .= " AND "; | |||
| } | |||
| $query .= " object_type = '".$objects_type_tab[$otype]."' "; | |||
| $query .= " object_type = '".$pearDB->escape($objects_type_tab[$otype])."' "; | |||
| $query .= " ORDER BY action_log_date DESC LIMIT ".$num * $limit.", ".$limit; | ||
|
|
||
| $query .= " ORDER BY action_log_date DESC LIMIT " | ||
| . (int)($num * $limit) . ", ". (int) $limit; |
Resolve MON-3227
kduret
approved these changes
Dec 11, 2018
callapa
suggested changes
Dec 11, 2018
| @@ -52,7 +52,7 @@ function searchUserName($user_name) | |||
| if ($str != "") { | |||
| $str .= ", "; | |||
| } | |||
| $str .= "'" . $row['contact_id'] . "'"; | |||
| $str .= "'" . $pearDB->escape($row['contact_id']) . "'"; | |||
There was a problem hiding this comment.
Why do you want to escape an integer value ?
In the centreon database, the structure of 'contact' indicates that contact_id is an integer.
When you are supposed to work with an integer value, please use the following syntax (int) $row['contact_id'].
miteto
approved these changes
Dec 11, 2018
Resolve MON-3227
callapa
approved these changes
Dec 11, 2018
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Resolve MON-3227