Fix a Javascript bug when the new header is selected #6590
Conversation
| $centreon->user->get_id() | ||
| ); | ||
| foreach($userFeatures as $feature) { | ||
| if($feature['name'] == 'Header' && $feature['enabled'] == 1) { |
There was a problem hiding this comment.
please add a space after the "foreach" and the "if" and split the line after the "&&" ->
'foreach ($userFeatures as $feature) {
'''' if ($feature['name'] == 'Header' &&
'''' '''' $feature['enabled'] == 1
'''' ) {
'''' ''' $headerVersion = (int) $feature['version'];
'''' }
'}
|
I've corrected the PSR2 -> https://github.com/centreon/centreon/tree/2.8.x/doc/coding-style |
The new header does not have the same identifier (header-react). Creating a variable containing the header identifier based on the selected header version.
adr-mo
force-pushed
the
MON-2797-fix-hostgroups-summary-with-new-header
branch
from
2f20206 to
4c7c052
Compare
|
Notification received because I've force pushed the branch to rebase it on the latest 2.8.x commit Validation can now start :) |
|
@adr-mo, I've created a PR (https://github.com/centreon/centreon/pull/6593) that i am going to need to keep up with, from all these push's until "mature" to merge. |
|
@lgcosta this PR is to correct a bug with the feature flipping new menu -> were hostgroups aren't displayed. |
|
@sc979 yeah, i know. what i mean is that every merge in branch 2.8.x, I will need to resolve conflict in the PR i quoted. So I will have to keep following the evolution of this branch ;-) |
|
ENV validation done using docker images built from rebased branch MON-2797-fix-hostgroups-summary-with-new-header (id: 4c7c052) Validation OK Can now be merged on 2.8.x branch |
The new header does not have the same identifier (header-react). Creating a variable containing the header identifier based on the selected header version.