6530 standardize mail notifications

[adr-mo]

Simple replica of #6530 .

Work has been rebased on the latest 2.8.x
New branch created for CI matters (validation and automatic tests modified)

Code validation has been already done.

[adr-mo]

Looks good to me can now be merged on the 2.8.x

[UrBnW]

Thank you @adr-mo 👍
I wondered whether or not <str> would have to be changed to <str>, but sounds then like no.
But re-reading the changes, I would say some " have useless $ sign in front of them.
For example :
-r $&quot;Centreon <centreon-engine>$&quot; -S replyto=$&quot;Centreon admin <$ADMINEMAIL$>$&quot;
Finally would require some update I think.

[UrBnW]

I've corrected in the initial PR #6530.

[adr-mo]

If it worth changing the code do not hesitate to do so 😊 I'll do the validation one more time there is no issue with that 😉

[UrBnW]

Thank you 👍
I've submitted 2 additional Typo commits to the initial PR, you can go !

[adr-mo]

Ok perfect I will cherry-pick them to this branch and validate the PR.

Thanks again for the contribution 😉

[UrBnW]

In addition, do you know why " are replaces by the HTML entity " ?
The notification commands are the only ones to use this "trick".
All other ones use ".
In addition, if you add a command through Crenteon GUI and then look at the inserted MySQL line, you'll see ", not ".
Do you think we could get rid of them ?

[adr-mo]

@cpbn I don't know, maybe @lpinsivy or @leoncx could answer to your question :)

[UrBnW]

Thank you @adr-mo, let's then wait for their answer before merging 👍

[leoncx]

The " is present because we convert the string into html entities, in old Centreon Web code the convert is done before the insert into the databases. We fix the code during time, normally the convert of special characters must be done during render of html.

[UrBnW]

Thank you @leoncx 👍
So we can now safely replace these HTML entities by their corresponding characters, right ?

[UrBnW]

We can also go like this, the " vs " is not really important, rather cosmetic, making code easier to read :)

[chgautier]

Modifications on branch 6530-standardize-mail-notifications OK. Header and Body looking good.