This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(acl): Host number calculation with ACL is not correct in HG summary #6436
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
For users with ACL, the SQL request get the list of all host / service couple and not only host list.
sc979
approved these changes
Jul 4, 2018
kduret
approved these changes
Jul 4, 2018
|
In 2.8.25 + this fix, limited user (with ACL resources configured) see no host and no host groups (could be due to ACL issue and not to the fix) |
|
@thiuyendang it is working in 2.8.25 without this fix? I suppose it is another issue |
|
In 2.8.25, limited user can see HG summary view but number of hosts is wrong. I have generated build on PR directly and when using the container, I've got an issue with limited user who cannot see no hosts neither host groups at all so I don't think that it is due to the fix committed in this PR 6436. But as I don"t see hosts, I cannot check the hosts number in HG summary view. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
For users with ACL, the SQL request get the list of all host / service couple and not only host list.