This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
-
Notifications
You must be signed in to change notification settings - Fork 240
fix(db): remove duplicate entries in centreon_acl table #6366
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
sc979
force-pushed
the
MON-2723_Update_centAcl_support
branch
2 times, most recently
from
June 13, 2018 15:41
fb2ecf7
to
4f4c0b3
Compare
kduret
suggested changes
Jun 13, 2018
/** | ||
* Retrieving index occurrences and dropping keys | ||
*/ | ||
$search_index = 'SHOW INDEX FROM centreon_storage.centreon_acl WHERE Key_name LIKE \'index%\''; |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not use "centreon_storage" name directly. Some people have custom db name.
If you use pearDBO variable, you use storage database, so you don't need to specify it.
/** | ||
* Stopping the cron | ||
*/ | ||
shell_exec('sudo service crond stop'); |
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
do not stop service in upgrade process.
You have to implement a system to stop temporarily centAcl cron
sc979
force-pushed
the
MON-2723_Update_centAcl_support
branch
2 times, most recently
from
June 14, 2018 14:29
ce3382d
to
b330aee
Compare
sc979
force-pushed
the
MON-2723_Update_centAcl_support
branch
from
June 15, 2018 16:43
b330aee
to
77988c2
Compare
kduret
force-pushed
the
MON-2723_Update_centAcl_support
branch
from
June 19, 2018 14:03
0d78379
to
e7fdab3
Compare
kduret
changed the title
fix(DB): upgrade DB to correct a bug
fix(db): remove duplicate entries in centreon_acl table
Jun 19, 2018
Ridene
approved these changes
Jun 19, 2018
jdelpierre
approved these changes
Jun 19, 2018
kduret
approved these changes
Jun 20, 2018
kduret
pushed a commit
that referenced
this pull request
Jun 25, 2018
* fix(DB): upgrade DB to correct a bug * fix(DB): centAcl close DB connection before the update is achieved * fix(acl): Add primary key and handle duplicate entries in centreon_acl * fix(sql): delete duplicate entries in centreon_acl table * feat(install): add base version to 2.8.24 * doc(upgrade): add empty release notes for 2.8.24
lpinsivy
added a commit
that referenced
this pull request
Nov 26, 2018
Since PR #6366, all values for host are: <host_id>,0 and not <host_id>,NULL
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Removing MUL key with PRI key
Avoiding to launch the patch when customers service already applied it