Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(macro) host/service macro visibility #5873

Merged
merged 2 commits into from
Nov 10, 2017
Merged

fix(macro) host/service macro visibility #5873

merged 2 commits into from
Nov 10, 2017

Conversation

loiclau
Copy link
Contributor

@loiclau loiclau commented Nov 9, 2017 •
edited
Loading

cherry-pick on master

@ganoze ganoze merged commit 053c9e9 into 2.8.x Nov 10, 2017
@ganoze ganoze deleted the fix-macro-password-visibility branch November 10, 2017 09:23
@adr-mo
Copy link
Contributor

adr-mo commented Nov 21, 2017

Before applying the patch

  • I've added a custom macro to a service and defined it as a password.
  • I've saved the configuration
  • When going back on the service definition the password was visible and "password" checkbox was unchecked.

Applying the patch has solved the problem and the password remains a password.

Looks good to me

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@MatthieuMan MatthieuMan MatthieuMan approved these changes

@Guillaume28 Guillaume28 Guillaume28 approved these changes

Assignees
No one assigned
Labels
area/configuration kind/bug priority/minor
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
6 participants
@loiclau @adr-mo @Guillaume28 @MatthieuMan @lpinsivy @ganoze