This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(security) Secure upload images #5863
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loiclau
force-pushed
the
secure-upload
branch
from
5a5914f to
772679a
Compare
kduret
suggested changes
Nov 8, 2017
www/class/centreonFileManager.php
Outdated
| @@ -0,0 +1,175 @@ | |||
| <?php | |||
| /** | |||
There was a problem hiding this comment.
Missing Centreon License header
www/class/centreonImageManager.php
Outdated
| @@ -0,0 +1,187 @@ | |||
| <?php | |||
| /** | |||
There was a problem hiding this comment.
Missing Centreon License header
www/class/iFileManager.php
Outdated
| @@ -0,0 +1,15 @@ | |||
| <?php | |||
| /** | |||
There was a problem hiding this comment.
Missing Centreon License header
www/class/centreonImageManager.php
Outdated
| $this->comment | ||
| ); | ||
| return $img_ids; | ||
| } |
| //update relation | ||
| $query = "UPDATE view_img_dir_relation SET dir_dir_parent_id = '" . $dirId . | ||
| "' WHERE img_img_id = '" . $imgId . "'"; | ||
| $pearDB->query($query); |
| @@ -216,7 +220,7 @@ | |||
| } | |||
| $action = $form->getSubmitValue("action"); | |||
|
|
|||
| if ($valid) { | |||
| if (is_array($valid)) { | |||
There was a problem hiding this comment.
strange validation. I think methods need to return "false" if update or upload doesn't work
kduret
approved these changes
Nov 8, 2017
Guillaume28
approved these changes
Nov 9, 2017
|
I've tried to upload php and js using image format (extensions and headers). Even if file is uploaded, I could not figure out how to execute it. Everything looks good to me. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Thanks to Sammy FORGIT from Certilience (www.certilience.fr) for having transmitted us the proof of concepts of vulnerabilities