Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(kb): increase page limit for mediawiki migration #5798

Merged
merged 2 commits into from
Nov 8, 2017
Merged

Conversation

kduret
Copy link
Contributor

@kduret kduret commented Oct 18, 2017

No description provided.

Copy link
Contributor

@ganoze ganoze left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

This fix seems incorrect to me as it only increase the number of pages returned by the API call. It should instead be a loop of call using the apcontinue parameter.

@kduret kduret merged commit 592d324 into 2.8.x Nov 8, 2017
@ganoze ganoze deleted the wikiGetAllPages branch November 10, 2017 09:32
@thiuyendang
Copy link
Contributor

OK for Hosts, Hosts templates, Services Templates
KO for Services

@thiuyendang thiuyendang self-assigned this Nov 14, 2017
@lpinsivy
Copy link
Contributor

@thiuyendang same class for four objects, can you retry for services and check with dev?

@thiuyendang
Copy link
Contributor

Saw with kduret : another PR will fix the issue for services pages rename

Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants