This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
API: Add HOST getparam #5783
Merged
API: Add HOST getparam #5783
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kduret
suggested changes
Oct 16, 2017
| $ret = $ret[$field]; | ||
| break; | ||
| } | ||
| echo $ret."\n"; |
| throw new CentreonClapiException(self::MISSINGPARAMETER); | ||
| } | ||
| $p = $this->object->getParameters($params[0], $params[1]); | ||
| print $p[$params[1]]."\n"; |
|
@kduret ping |
kduret
approved these changes
Nov 9, 2017
loiclau
suggested changes
Nov 9, 2017
| $ret = $extended->getParameters($objectId, $field); | ||
| $ret = $ret[$field]; | ||
| } | ||
| switch ($params[1]) { |
There was a problem hiding this comment.
The switch is the same as that employed
There was a problem hiding this comment.
Yes. But this one is to convert parameter value if needed. Otherwise, the ->getParameters would be duplicated.
loiclau
approved these changes
Nov 10, 2017
loiclau
added a commit
that referenced
this pull request
Nov 27, 2017
loiclau
added a commit
that referenced
this pull request
Nov 27, 2017
Guillaume28
pushed a commit
that referenced
this pull request
Nov 30, 2017
Guillaume28
pushed a commit
that referenced
this pull request
Nov 30, 2017
* fix(doc) doc for host get param #5783 * API: Add HOST getparam
|
thanks for your contribution |
|
UPDATE: #5946 (add possibility to get several params and fix 3 variables not found) |
|
Looks good to me. Tested with the latest update brought by #5946. |
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes: #4343