This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Manage downtimes with dst (recurrent and realtime) #5780
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
loiclau
suggested changes
Oct 13, 2017
| $dateTime = new \DateTime($date, new \DateTimeZone($timezone)); | ||
|
|
||
| // Winter to summer dst | ||
| $dateTime2 = clone($dateTime); |
There was a problem hiding this comment.
clone $dateTime without incidentally
loiclau
approved these changes
Oct 16, 2017
loiclau
suggested changes
Oct 16, 2017
| { | ||
| $dstDate = new DateTime('now', $timezone); | ||
| $dstDate->setTimestamp($timestamp); | ||
| $dateTime2 = clone($dstDate); |
MatthieuMan
suggested changes
Oct 16, 2017
| ); | ||
| $output = $return['output']; | ||
| if ( | ||
| preg_match_all( |
There was a problem hiding this comment.
Styles: phpcs mark this new line as an error
MatthieuMan
suggested changes
Oct 16, 2017
| ); | ||
| $output = $return['output']; | ||
| if ( | ||
| preg_match( |
There was a problem hiding this comment.
Styles: phpcs mark this new line as an error (339)
MatthieuMan
approved these changes
Oct 17, 2017
loiclau
approved these changes
Oct 17, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
to cherry-pick on master
An other pull request is coming for 2.7.x