This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Correct svc top counter with meta and merge SQL requests #5616
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Please do a complete benchmark with more that 100 000 svc before validating this PR. It's very touchy to change code on this part. |
|
Please find the result of the bench
|
Dacchi
suggested changes
Sep 4, 2017
…ion of meta-services status
lpinsivy
force-pushed
the
5458-Metaservices-not-counted-properly-in-statuses-filter
branch
from
029ecab to
728623d
Compare
|
Done ! |
Dacchi
approved these changes
Sep 6, 2017
ganoze
deleted the
5458-Metaservices-not-counted-properly-in-statuses-filter
branch
lpinsivy
added a commit
that referenced
this pull request
Sep 25, 2017
Add SELECT DISTINCT to do not count twice services
ganoze
pushed a commit
that referenced
this pull request
Sep 29, 2017
Add SELECT DISTINCT to do not count twice services
lpinsivy
added a commit
that referenced
this pull request
Oct 13, 2017
ganoze
pushed a commit
that referenced
this pull request
Oct 18, 2017
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
fix(monitoring) : Metaservices not counted properly in statuses filter
Merge SQL requests for statuses of services to:
This allow to correct issue with calculation of Meta-services
refs: #5458