Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

5300 api gesthosts add json keys #5603

Merged
merged 3 commits into from
Sep 21, 2017
Merged

Conversation

lpinsivy
Copy link
Contributor

fix(api): API For Gesthosts method on Instance object add json keys

Add missing keys to correct json export
Add control to do not export "_Module.*" virtual hosts
Improve API test:

  • Add application/json header content-type test
  • Add body contains entries test
  • Add json schema validation test
  • Add no _Module host presence test
  • Improve presence of host test

refs: #5300

@leoncx leoncx self-requested a review August 29, 2017 06:34
@lpinsivy lpinsivy added this to the 2.8.13 milestone Sep 7, 2017
@lpinsivy lpinsivy modified the milestones: 2.8.14, 2.8.13 Sep 11, 2017
@loiclau loiclau self-requested a review September 14, 2017 13:53
@ganoze
Copy link
Contributor

ganoze commented Sep 20, 2017

PR is approved and CI is OK. Should it be cherry-picked as is to the master branch ?

@ganoze ganoze merged commit 783c9e4 into 2.8.x Sep 21, 2017
@ganoze ganoze deleted the 5300-api-gesthosts-add-json-keys branch September 21, 2017 09:04
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants