Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

New feature TrapSNMPGroup #5542

Merged
merged 3 commits into from
Oct 25, 2017
Merged

New feature TrapSNMPGroup #5542

merged 3 commits into from
Oct 25, 2017

Conversation

mariegallardo
Copy link
Contributor

No description provided.

@kduret
Copy link
Contributor

kduret commented Aug 16, 2017

Waiting fix on trap groups foreign key

@kduret kduret self-requested a review August 31, 2017 07:19
kduret
kduret previously requested changes Aug 31, 2017
Copy link
Contributor

@kduret kduret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Does not work until traps_group table is not the same between fresh install and upgrade

@Dacchi Dacchi self-assigned this Sep 14, 2017
@ganoze
Copy link
Contributor

ganoze commented Oct 6, 2017

Tests should be OK now. However traps associated to a group are not properly printed when editing a group (vendor is missing).

MatthieuMan and others added 2 commits October 24, 2017 17:20
getDefaultValues method from Api overridden with a new query to get the missing vendor

Refs:pr5542
@ganoze ganoze added this to the 2.8.16 milestone Oct 25, 2017
@ganoze ganoze dismissed kduret’s stale review October 25, 2017 07:04

All changes requested were addressed.

@ganoze ganoze merged commit 464944b into 2.8.x Oct 25, 2017
@ganoze ganoze deleted the FeatureTrapGroup branch October 25, 2017 07:06
ganoze pushed a commit that referenced this pull request Oct 26, 2017
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

7 participants