Ldap manual import #5381
Ldap manual import #5381
Conversation
…ceptance test added
features/LdapManualImport.feature
Outdated
| Given I am logged in a Centreon server | ||
| And a LDAP configuration has been created | ||
| And LDAP authentication is enabled | ||
| And users auto import is disabled |
There was a problem hiding this comment.
Too much "And" :
Given I am logged in a Centreon server
And a LDAP configuration has been created
And users auto import is disabled
| if ($value != 0) { | ||
| throw new Exception('Users auto import enabled'); | ||
| } | ||
|
|
There was a problem hiding this comment.
be careful about blank lines (coding style)
| $this->assertFindLink('openldap')->click(); | ||
| sleep(5); | ||
| $this->assertFindButton('Import users manually')->click(); | ||
|
|
There was a problem hiding this comment.
be careful about blank lines (coding style)
| { | ||
| sleep(5); | ||
| $this->assertFindButton('Search')->click(); | ||
|
|
There was a problem hiding this comment.
be careful about blank lines (coding style)
| sleep(5); | ||
| $this->assertFind('css', 'input[name="contact_select[select][3]"]')->click(); | ||
| $this->assertFindButton('submitA')->click(); | ||
|
|
There was a problem hiding this comment.
be careful about blank lines (coding style)
|
|
||
| throw new Exception(' contact not created '); | ||
| } | ||
|
|
There was a problem hiding this comment.
be careful about blank lines (coding style)
| $this->iSearchASpecificUserWhoseAliasContainsASpecialCharacterSuchAsAnAccent(); | ||
| $this->theLdapSearchResultDisplaysTheExpectedAlias(); | ||
| $this->iImportTheUser(); | ||
|
|
There was a problem hiding this comment.
be careful about blank lines (coding style)
| */ | ||
| public function thisUserLoginsToCentreonWeb() | ||
| { | ||
| $this->iAmLoggedOut(); |
There was a problem hiding this comment.
I think it's not the better way to check login
| { | ||
| $this->page = new LoginPage($this); | ||
| $this->page->login($this->alias, 'centreon-ldap4'); | ||
|
|
There was a problem hiding this comment.
be careful about blank lines (coding style)
| $object = $this->page->getEntry('openldap'); | ||
|
|
||
| if ($object['status'] != 'Enabled') { | ||
| throw new Exception(' LDAP authentification is disabled'); |
There was a problem hiding this comment.
fr: authentification
en: authentication
|
Furthermore, use spin method instead of sleep ;) |
|
changes done |
* ldapLDAPManualImport config added into behat.yml * LdapManualImport and LdapManualImportContext.php.feature files for acceptance test added * feature's background modified * LdapManualImportContext.php accpetance test ok * LdapManuelImport acceptance test enhanced * UtilsContext Class withdrawn * features's name modified * improve acceptance test for ldap manual import * improve ldap manual import acceptance test
acceptance test ok