Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(db): change type of notification_number column 21.10 #11892

Merged
merged 1 commit into from
Sep 28, 2022
Merged

fix(db): change type of notification_number column 21.10 #11892

merged 1 commit into from
Sep 28, 2022

Conversation

dmyios
Copy link
Contributor

@dmyios dmyios commented Sep 28, 2022

Description

This is a fix on PR https://github.com/centreon/centreon/pull/11863 hadling the case when notification_number is inferior to 0 during update to 21.10.11

Fixes # MON-14223

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 21.04.x
  • 21.10.x
  • 22.04.x
  • 22.10.x (master)

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@dmyios dmyios requested review from a team, callapa and wtermellil and removed request for a team September 28, 2022 12:14
@dmyios dmyios changed the title fixed issue where notification number < 0 before update fix(db): change type of notification_number column Sep 28, 2022
@dmyios dmyios changed the title fix(db): change type of notification_number column fix(db): change type of notification_number column 21.10 Sep 28, 2022
@sonarqube-decoration
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@dmyios dmyios merged commit 13e1c55 into release-21.10.next Sep 28, 2022
@dmyios dmyios deleted the MON-14223-fix-overflow-21.10 branch September 28, 2022 12:55
@kduret kduret restored the MON-14223-fix-overflow-21.10 branch October 4, 2022 16:19
@kduret kduret deleted the MON-14223-fix-overflow-21.10 branch October 4, 2022 16:19
@kduret kduret restored the MON-14223-fix-overflow-21.10 branch October 5, 2022 06:34
@kduret kduret mentioned this pull request Oct 5, 2022
Merged
7 tasks
@kduret kduret deleted the MON-14223-fix-overflow-21.10 branch October 5, 2022 06:36
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@adr-mo adr-mo adr-mo approved these changes

@callapa callapa Awaiting requested review from callapa

@wtermellil wtermellil Awaiting requested review from wtermellil

Assignees
No one assigned
Labels
area/backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@dmyios @adr-mo