Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Fix: Remove obsolete code in legacy service detail page #11848

Merged
merged 3 commits into from
Sep 27, 2022
Merged

Fix: Remove obsolete code in legacy service detail page #11848

Changes from all commits
Commits
Show all changes
3 commits
Select commit Hold shift + click to select a range
b61bb99
Remove obsolete code in legacy service detail page
emabassi-ext Sep 21, 2022
eacfca6
restore deleted codeÃ
emabassi-ext Sep 26, 2022
bd7d23a
remove obsolete code in legacy service detail page and query sanitizeÃ
emabassi-ext Sep 26, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
19 changes: 8 additions & 11 deletions www/include/monitoring/objectDetails/serviceDetails.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -619,18 +619,17 @@
$status .= "&value[" . $key . "]=" . $value;
}

$optionsURL = "host_name=" . urlencode($host_name) . "&service_description=" . urlencode($svc_description);

$query = "SELECT id FROM `index_data`, `metrics` WHERE host_name = '" . $pearDBO->escape($host_name) .
"' AND service_description = '" . $pearDBO->escape($svc_description) . "' AND id = index_id LIMIT 1";
$DBRES = $pearDBO->query($query);
$query = "SELECT id FROM `index_data`, `metrics` WHERE host_name = :host_name" .
" AND service_description = :svc_description AND id = index_id LIMIT 1";
$statement = $pearDBO->prepare($query);
$statement->bindValue(':host_name', $host_name, \PDO::PARAM_STR);
$statement->bindValue(':svc_description', $svc_description, \PDO::PARAM_STR);
$statement->execute();
$index_data = 0;
emabassi-ext marked this conversation as resolved.
Show resolved Hide resolved
if ($DBRES->rowCount()) {
$row = $DBRES->fetchRow();
if ($statement->rowCount()) {
$row = $statement->fetchRow();
$index_data = $row['id'];
}
$optionsURL2 = "index=" . $index_data;

/*
* Assign translations
*/
Expand Down Expand Up @@ -873,9 +872,7 @@
$tpl->assign("sv_ext_action_url_lang", _("Action URL"));
$tpl->assign("sv_ext_action_url", CentreonUtils::escapeSecure($actionurl));
$tpl->assign("sv_ext_icon_image_alt", getMyServiceExtendedInfoField($service_id, "esi_icon_image_alt"));
$tpl->assign("options", $optionsURL);
$tpl->assign("index_data", $index_data);
$tpl->assign("options2", CentreonUtils::escapeSecure($optionsURL2));

/**
* Build the service detail URI that will be used in the
Expand Down