This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Fix: Remove obsolete code in database partitioning functions #11810
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Queries should be sanitized (if possible) and bound using PDO statement to reduce attack surface and clean legacy code
Where
www/class/centreon-partition/partEngine.class.php
Remove optimizeTablePartitions function
Fixes # MON-14974
Type of change
Target serie
How this pull request can be tested ?
Get number of current partition for “data_bin”:
ls /var/lib/mysql/centreon_storage/ | egrep data_bin#P#* | wc -l
38
Increase “Forward provisioning” from “Administration > Parameters > Options” menu (+10)
Run script manually
/usr/bin/php /usr/share/centreon/cron/centreon-partitioning.php
Check that partitions have been created using:
ls /var/lib/mysql/centreon_storage/ | egrep data_bin#P#* | wc -l
48
Reduce “Retention duration for performance data in MySQL database” from “Administration > Parameters > Options” menu
Run script manually
/usr/bin/php /usr/share/centreon/cron/centstorage_purge.php
Check that partitions have been deleted
ls /var/lib/mysql/centreon_storage/ | egrep data_bin#P#* | wc -l
35
Checklist
Community contributors & Centreon team