This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Fix: Remove obsolete code in Criticality class #11783
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
emabassi-ext
requested review from
kduret,
jeremyjaouen,
dmyios,
wtermellil and
a team
TamazC
reviewed
Sep 19, 2022
| } | ||
| } | ||
| return null; | ||
| } | ||
| } |
There was a problem hiding this comment.
you have to remove line break in line 361
|
SonarQube Quality Gate
|
100.0% reviewed)
callapa
approved these changes
Sep 20, 2022
TamazC
approved these changes
Sep 20, 2022
emabassi-ext
deleted the
MON-14972-remove-obsolete-code-in-criticality-class
branch
emabassi-ext
added a commit
that referenced
this pull request
Sep 21, 2022
* remove obsolete function getHostTplCriticality in criticality class * Update www/class/centreonCriticality.class.php Co-authored-by: TamazC <103252125+TamazC@users.noreply.github.com>
emabassi-ext
added a commit
that referenced
this pull request
Sep 21, 2022
* remove obsolete function getHostTplCriticality in criticality class * Update www/class/centreonCriticality.class.php Co-authored-by: TamazC <103252125+TamazC@users.noreply.github.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
The getHostTplCriticities called itself but is not called by Centreon or modules.
File: www/class/centreonCriticality.class.php
Remove function getHostTplCriticities
Fixes # MON-14972
Type of change
Target serie
How this pull request can be tested ?
no tests fo this PR ## ChecklistCommunity contributors & Centreon team