Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

Fix: Sanitize and bind Media import #11772

Merged
merged 1 commit into from
Sep 19, 2022
Merged

Fix: Sanitize and bind Media import #11772

merged 1 commit into from
Sep 19, 2022

Conversation

emabassi-ext
Copy link
Contributor

Description

Queries should be sanitized (if possible) and bound using PDO statement to reduce attack surface and clean legacy code

Where:

www/class/centreonMedia.class.php

Line: 423

Fixes # MON-14973

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 21.04.x
  • 21.10.x
  • 22.04.x
  • 22.10.x (master)

How this pull request can be tested ?

Add a new image in Centreon from “Administration > Parameters > Images”

Valide that image have been imported

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@emabassi-ext emabassi-ext self-assigned this Sep 15, 2022
@sonarqube-decoration
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug B 7 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots (100.0% 100.0% reviewed)
Code Smell A 2047 Code Smells

0.0% 0.0% Coverage
4.1% 4.1% Duplication

@emabassi-ext emabassi-ext merged commit 999711d into develop Sep 19, 2022
@emabassi-ext emabassi-ext deleted the MON-14973-sanitize-and-bind-media-import branch September 19, 2022 08:00
emabassi-ext added a commit that referenced this pull request Sep 19, 2022
@emabassi-ext
Fix: Sanitize and bind Media import (#11772)
746028c
emabassi-ext added a commit that referenced this pull request Sep 19, 2022
@emabassi-ext
Fix: Sanitize and bind Media import (#11772)
2455a74
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dmyios dmyios dmyios approved these changes

@jeremyjaouen jeremyjaouen jeremyjaouen approved these changes

@kduret kduret Awaiting requested review from kduret

@hyahiaoui-ext hyahiaoui-ext Awaiting requested review from hyahiaoui-ext

@wtermellil wtermellil Awaiting requested review from wtermellil

Assignees

@emabassi-ext emabassi-ext

Labels
area/backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@emabassi-ext @jeremyjaouen @dmyios