Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

FIX: Remove unused mechanism for modules to add restart/reload actions after restart of pollers #11771

Merged
merged 2 commits into from
Sep 20, 2022
Merged

FIX: Remove unused mechanism for modules to add restart/reload actions after restart of pollers #11771

merged 2 commits into from
Sep 20, 2022

Conversation

hyahiaoui-ext
Copy link
Contributor

Description

A mechanism was added in Centreon 2.6.2 (September 2015) to allow module to add reload/restart actions after restart of pollers, this PR will take care of removing it.

Fixes # MON-14952

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 21.04.x
  • 21.10.x
  • 22.04.x
  • 22.10.x (master)

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@hyahiaoui-ext hyahiaoui-ext self-assigned this Sep 15, 2022
@hyahiaoui-ext hyahiaoui-ext requested a review from a team September 15, 2022 15:32
a-launois
a-launois previously approved these changes Sep 16, 2022
View reviewed changes
@hyahiaoui-ext hyahiaoui-ext force-pushed the MON-14952-remove-unused-mechanism-restart-reload-pollers branch from 03845d0 to e25f991 Compare September 19, 2022 10:45
@sonarqube-decoration
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug C 8 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots (100.0% 100.0% reviewed)
Code Smell A 2075 Code Smells

0.0% 0.0% Coverage
4.1% 4.1% Duplication

@hyahiaoui-ext hyahiaoui-ext merged commit 8e0c0ab into develop Sep 20, 2022
@hyahiaoui-ext hyahiaoui-ext deleted the MON-14952-remove-unused-mechanism-restart-reload-pollers branch September 20, 2022 23:15
hyahiaoui-ext added a commit that referenced this pull request Sep 22, 2022
@hyahiaoui-ext
FIX: Remove unused mechanism for modules to add restart/reload action…
8683227 
…s after restart of pollers (#11771)

* removing obsolet code

* removing more useless code
hyahiaoui-ext added a commit that referenced this pull request Sep 22, 2022
@hyahiaoui-ext
FIX: Remove unused mechanism for modules to add restart/reload action…
f617cda 
…s after restart of pollers (#11771)

* removing obsolet code

* removing more useless code
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@jeremyjaouen jeremyjaouen jeremyjaouen approved these changes

@kduret kduret kduret approved these changes

@callapa callapa callapa approved these changes

@a-launois a-launois Awaiting requested review from a-launois

Assignees

@hyahiaoui-ext hyahiaoui-ext

Labels
area/backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
5 participants
@hyahiaoui-ext @callapa @kduret @jeremyjaouen @a-launois