This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
FIX: Removing unused code and fixing bug of generating csv in multiple periods graphs #11742
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
hyahiaoui-ext
requested review from
callapa,
kduret,
jeremyjaouen,
a-launois and
dmyios
hyahiaoui-ext
force-pushed
the
MON-14927-remove-obselete-code-and-fix-bug-csv
branch
from
df9e966 to
1a67dc3
Compare
TamazC
reviewed
Sep 12, 2022
hyahiaoui-ext
force-pushed
the
MON-14927-remove-obselete-code-and-fix-bug-csv
branch
from
1a67dc3 to
c91f372
Compare
TamazC
approved these changes
Sep 16, 2022
kduret
reviewed
Sep 19, 2022
jeremyjaouen
approved these changes
Sep 19, 2022
|
SonarQube Quality Gate
|
100.0% reviewed)
kduret
approved these changes
Sep 20, 2022
hyahiaoui-ext
deleted the
MON-14927-remove-obselete-code-and-fix-bug-csv
branch
hyahiaoui-ext
added a commit
that referenced
this pull request
Sep 22, 2022
…e periods graphs (#11742)
hyahiaoui-ext
added a commit
that referenced
this pull request
Sep 22, 2022
…e periods graphs (#11742)
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
While in multiple periods graphs we can't generate csv nor an image, this should take care of it also removing some unused code to clean up the code base.
Fixes # MON-14927
Type of change
Target serie
Checklist
Community contributors & Centreon team