Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

[SNYK] Sanitize and bind listVirtualMetrics queries #11649

Merged
merged 1 commit into from
Aug 30, 2022
Merged

[SNYK] Sanitize and bind listVirtualMetrics queries #11649

Changes from all commits
Commits
Show all changes
1 commit
Select commit
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
52 changes: 30 additions & 22 deletions www/include/views/virtualMetrics/listVirtualMetrics.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -130,37 +130,45 @@
"\" maxlength=\"3\" size=\"3\" value='1' style=\"margin-bottom:0px;\" name='dupNbr[" .
$vmetric['vmetric_id'] . "]' />";

$indexDataStatement = $pearDBO->prepare("SELECT id,host_id,service_id FROM index_data " .
"WHERE id = :indexId ");
try {
$query = "SELECT id,host_id,service_id FROM index_data WHERE id = '" . $vmetric['index_id'] . "'";
$dbindd = $pearDBO->query($query);
$indexDataStatement->bindValue(':indexId', (int) $vmetric['index_id'], \PDO::PARAM_INT);
$indexDataStatement->execute();
} catch (\PDOException $e) {
print "DB Error : " . $e->getMessage() . "<br />";
}
$indd = $dbindd->fetchRow();
$dbindd->closeCursor();
try {
$query = "(SELECT concat(h.host_name,' > ',s.service_description) full_name " .
"FROM host_service_relation AS hsr, host AS h, service AS s WHERE hsr.host_host_id = h.host_id " .
"AND hsr.service_service_id = s.service_id AND h.host_id = '" . $indd["host_id"] .
"' AND s.service_id = '" . $indd["service_id"] . "') UNION " .
"(SELECT concat(h.host_name,' > ',s.service_description) full_name " .
"FROM host_service_relation AS hsr, host AS h, service AS s, hostgroup_relation AS hr " .
"WHERE hsr.hostgroup_hg_id = hr.hostgroup_hg_id AND hr.host_host_id = h.host_id " .
"AND hsr.service_service_id = s.Service_id AND h.host_id = '" . $indd["host_id"] .
"' AND s.service_id = '" . $indd["service_id"] . "') ORDER BY full_name";
$dbhsrname = $pearDB->query($query);
} catch (\PDOException $e) {
print "DB Error : " . $e->getMessage() . "<br />";
$indd = $indexDataStatement->fetchRow();

$indexDataStatement->closeCursor();
if ($indd !== false) {
try {
$hsrStatement = $pearDB->prepare("(SELECT concat(h.host_name,' > ',s.service_description) full_name " .
"FROM host_service_relation AS hsr, host AS h, service AS s WHERE hsr.host_host_id = h.host_id " .
"AND hsr.service_service_id = s.service_id AND h.host_id = :hostId " .
"AND s.service_id = :serviceId ) UNION " .
"(SELECT concat(h.host_name,' > ',s.service_description) full_name " .
"FROM host_service_relation AS hsr, host AS h, service AS s, hostgroup_relation AS hr " .
"WHERE hsr.hostgroup_hg_id = hr.hostgroup_hg_id AND hr.host_host_id = h.host_id " .
"AND hsr.service_service_id = s.Service_id AND h.host_id = :hostId " .
"AND s.service_id = :serviceId ) ORDER BY full_name");

$hsrStatement->bindValue(':hostId', (int) $indd["host_id"], \PDO::PARAM_INT);
$hsrStatement->bindValue(':serviceId', (int) $indd["service_id"], \PDO::PARAM_INT);
$hsrStatement->execute();
} catch (\PDOException $e) {
print "DB Error : " . $e->getMessage() . "<br />";
}
$hsrname = $hsrStatement->fetchRow();
$hsrStatement->closeCursor();
$hsrname["full_name"] = str_replace('#S#', "/", $hsrname["full_name"]);
$hsrname["full_name"] = str_replace('#BS#', "\\", $hsrname["full_name"]);
}
$hsrname = $dbhsrname->fetchRow();
$dbhsrname->closeCursor();
$hsrname["full_name"] = str_replace('#S#', "/", $hsrname["full_name"]);
$hsrname["full_name"] = str_replace('#BS#', "\\", $hsrname["full_name"]);

### TODO : data_count
$elemArr[$i] = array(
"MenuClass" => "list_" . $style,
"title" => $hsrname["full_name"],
"title" => $hsrname["full_name"] ?? null,
"RowMenu_select" => $selectedElements->toHtml(),
"RowMenu_ckstate" => $vmetric["ck_state"],
"RowMenu_name" => $vmetric["vmetric_name"],
Expand Down