Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

SNYK: Sanitize and bind Meta-Services dependency queries #11554

Merged
merged 2 commits into from
Aug 11, 2022
Merged

SNYK: Sanitize and bind Meta-Services dependency queries #11554

Changes from all commits
Commits
Show all changes
2 commits
Select commit Hold shift + click to select a range
b014199
sanityze 2 insert queries
emabassi-ext Aug 9, 2022
ef36553
spaces removed in a queryÃ
emabassi-ext Aug 9, 2022
File filter

Filter by extension

Filter by extension
Conversations
Failed to load comments.
Loading
Jump to
Jump to file
Failed to load files.
Loading
Diff view
Diff view
16 changes: 10 additions & 6 deletions www/include/configuration/configObject/metaservice_dependency/DB-Func.php
View file
Open in desktop
Original file line number Diff line number Diff line change
Expand Up @@ -114,19 +114,23 @@ function multipleMetaServiceDependencyInDB($dependencies = array(), $nbrDup = ar
$query = "SELECT DISTINCT meta_service_meta_id FROM dependency_metaserviceParent_relation " .
"WHERE dependency_dep_id = '" . $key . "'";
$dbResult = $pearDB->query($query);
$statement = $pearDB->prepare("INSERT INTO dependency_metaserviceParent_relation " .
"VALUES (:maxId, :metaId)");
while ($ms = $dbResult->fetch()) {
$query = "INSERT INTO dependency_metaserviceParent_relation " .
"VALUES ('" . $maxId["MAX(dep_id)"] . "', '" . $ms["meta_service_meta_id"] . "')";
$pearDB->query($query);
$statement->bindValue(':maxId', (int) $maxId["MAX(dep_id)"], \PDO::PARAM_INT);
$statement->bindValue(':metaId', (int) $ms["meta_service_meta_id"], \PDO::PARAM_INT);
$statement->execute();
}
$dbResult->closeCursor();
$query = "SELECT DISTINCT meta_service_meta_id FROM dependency_metaserviceChild_relation " .
"WHERE dependency_dep_id = '" . $key . "'";
$dbResult = $pearDB->query($query);
$childStatement = $pearDB->prepare("INSERT INTO dependency_metaserviceChild_relation " .
"VALUES (:maxId, :metaId)");
while ($ms = $dbResult->fetch()) {
$query = "INSERT INTO dependency_metaserviceChild_relation VALUES ('" .
$maxId["MAX(dep_id)"] . "', '" . $ms["meta_service_meta_id"] . "')";
$pearDB->query($query);
$childStatement->bindValue(':maxId', (int) $maxId["MAX(dep_id)"], \PDO::PARAM_INT);
$childStatement->bindValue(':metaId', (int) $ms["meta_service_meta_id"], \PDO::PARAM_INT);
$childStatement->execute();
}
$dbResult->closeCursor();
}
Expand Down