Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

SNYK: Sanitize and bind Broker listing queries #11525

Merged
merged 2 commits into from
Aug 9, 2022
Merged

SNYK: Sanitize and bind Broker listing queries #11525

merged 2 commits into from
Aug 9, 2022

Conversation

hyahiaoui-ext
Copy link
Contributor

Description

Sanitizing and binding Broker listing input output count queries to avoid surface attacks and cleaning up legacy code.

Preview:
image

Fixes # MON-14498

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 21.04.x
  • 21.10.x
  • 22.04.x
  • 22.10.x (master)

Checklist

Community contributors & Centreon team

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have rebased my development branch on the base branch (master, maintenance).

@hyahiaoui-ext hyahiaoui-ext self-assigned this Aug 5, 2022
kduret
kduret previously approved these changes Aug 8, 2022
View reviewed changes
@hyahiaoui-ext hyahiaoui-ext requested a review from kduret August 8, 2022 11:11
kduret
kduret previously approved these changes Aug 8, 2022
View reviewed changes
@hyahiaoui-ext hyahiaoui-ext force-pushed the MON-14498-sanitize-broker-listing-queries branch from 69cd83a to d902858 Compare August 8, 2022 16:22
@sonarqube-decoration
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug B 3 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots (100.0% 100.0% reviewed)
Code Smell A 1327 Code Smells

0.0% 0.0% Coverage
4.0% 4.0% Duplication

@hyahiaoui-ext hyahiaoui-ext requested a review from kduret August 8, 2022 23:26
@hyahiaoui-ext hyahiaoui-ext merged commit ad546f0 into develop Aug 9, 2022
@hyahiaoui-ext hyahiaoui-ext deleted the MON-14498-sanitize-broker-listing-queries branch August 9, 2022 09:50
hyahiaoui-ext added a commit that referenced this pull request Aug 9, 2022
@hyahiaoui-ext
SNYK: Sanitize and bind Broker listing queries (#11525)
c8dfbb9 
* Sanitizing and binding broker listing queries

* applying suggested changes
hyahiaoui-ext added a commit that referenced this pull request Aug 9, 2022
@hyahiaoui-ext
SNYK: Sanitize and bind Broker listing queries (#11525)
b100a7a 
* Sanitizing and binding broker listing queries

* applying suggested changes
hyahiaoui-ext added a commit that referenced this pull request Aug 9, 2022
@hyahiaoui-ext
SNYK: Sanitize and bind Broker listing queries (#11525)
50d8bbf 
* Sanitizing and binding broker listing queries

* applying suggested changes
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@dmyios dmyios dmyios approved these changes

@kduret kduret kduret approved these changes

@callapa callapa Awaiting requested review from callapa

@jeremyjaouen jeremyjaouen Awaiting requested review from jeremyjaouen

@a-launois a-launois Awaiting requested review from a-launois

Assignees

@hyahiaoui-ext hyahiaoui-ext

Labels
area/backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@hyahiaoui-ext @kduret @dmyios