This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
enh(platform): Use API to select metrics in virtual metrics configuration form #11430
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
|
Hey dear reviewers 👋, i know i've made changes in the composer.json and lock files, just to test the build, i'll revert them after mergin the branch in "test-lib"! |
callapa
suggested changes
Jul 29, 2022
www/include/views/componentTemplates/formComponentTemplate.ihtml
Outdated
Show resolved
Hide resolved
|
SonarQube Quality Gate
|
100.0% reviewed)
callapa
approved these changes
Jul 29, 2022
callapa
approved these changes
Jul 29, 2022
jeremyjaouen
approved these changes
Jul 29, 2022
hyahiaoui-ext
added a commit
that referenced
this pull request
Jul 29, 2022
…tion form (#11430) * changing select with select2 of metrics * fix alignement * remove unecessary files and replace selec by select2 in formComponentTemplate * fix select id name for acceptance tests * update composer for acceptance tests * fix acceptance test 2 * add allow clear to metrics select2 * applying suggested changes * final changes for merging * remove unecessary select tag
hyahiaoui-ext
added a commit
that referenced
this pull request
Jul 29, 2022
…tion form (#11430) * changing select with select2 of metrics * fix alignement * remove unecessary files and replace selec by select2 in formComponentTemplate * fix select id name for acceptance tests * update composer for acceptance tests * fix acceptance test 2 * add allow clear to metrics select2 * applying suggested changes * final changes for merging * remove unecessary select tag
hyahiaoui-ext
added a commit
that referenced
this pull request
Jul 29, 2022
…tion form (#11430) * changing select with select2 of metrics * fix alignement * remove unecessary files and replace selec by select2 in formComponentTemplate * fix select id name for acceptance tests * update composer for acceptance tests * fix acceptance test 2 * add allow clear to metrics select2 * applying suggested changes * final changes for merging * remove unecessary select tag
hyahiaoui-ext
added a commit
that referenced
this pull request
Aug 1, 2022
…tion form (#11430) * changing select with select2 of metrics * fix alignement * remove unecessary files and replace selec by select2 in formComponentTemplate * fix select id name for acceptance tests * update composer for acceptance tests * fix acceptance test 2 * add allow clear to metrics select2 * applying suggested changes * final changes for merging * remove unecessary select tag
hyahiaoui-ext
added a commit
that referenced
this pull request
Aug 4, 2022
…tion form (#11430) * changing select with select2 of metrics * fix alignement * remove unecessary files and replace selec by select2 in formComponentTemplate * fix select id name for acceptance tests * update composer for acceptance tests * fix acceptance test 2 * add allow clear to metrics select2 * applying suggested changes * final changes for merging * remove unecessary select tag
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replacing www/include/views/graphs/common/makeXML_ListMetrics.php by the select2 for metrics
Listed metrics are from host/service couple selected in form
Previews:
Before:
After:
Fixes # MON-14359
Type of change
Target serie
Checklist
Community contributors & Centreon team