Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

enh(update): check platform requirements on updates API call #11361

Merged
merged 11 commits into from
Jul 15, 2022
Merged

enh(update): check platform requirements on updates API call #11361

merged 11 commits into from
Jul 15, 2022

Conversation

kduret
Copy link
Contributor

@kduret kduret commented Jul 11, 2022

Description

check platform requirements on updates API call

Fixes MON-12296

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software

Target serie

  • 21.04.x
  • 21.10.x
  • 22.04.x
  • 22.10.x (master)

How this pull request can be tested ?

Check API documentation to make an api call

@kduret kduret marked this pull request as ready for review July 11, 2022 14:08
@kduret kduret requested review from a team, callapa and adr-mo and removed request for a team July 11, 2022 14:08
smau-centreon
smau-centreon suggested changes Jul 11, 2022
View reviewed changes
lang/fr_FR.UTF-8/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
lang/fr_FR.UTF-8/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
lang/fr_FR.UTF-8/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
lang/fr_FR.UTF-8/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
lang/fr_FR.UTF-8/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
lang/fr_FR.UTF-8/LC_MESSAGES/messages.po Outdated Show resolved Hide resolved
kduret and others added 3 commits July 12, 2022 08:19
@kduret @smau-centreon
Apply suggestions from code review
9a2006a 
Co-authored-by: smau <102975713+smau-centreon@users.noreply.github.com>
@kduret
fix
6913968
@kduret @smau-centreon
Update lang/fr_FR.UTF-8/LC_MESSAGES/messages.po
f06d61b 
Co-authored-by: smau <102975713+smau-centreon@users.noreply.github.com>
kduret
kduret commented Jul 12, 2022
View reviewed changes
Copy link
Contributor Author

@kduret kduret left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

create validator directory instead of repository
create global database validator with provider for each type : MariaDBValidator, ...

@sonarqube-decoration
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots (100.0% 100.0% reviewed)
Code Smell A 739 Code Smells

0.0% 0.0% Coverage
4.3% 4.3% Duplication

@kduret kduret merged commit 6bc3722 into MON-12296 Jul 15, 2022
@kduret kduret deleted the MON-12296-requirements branch July 15, 2022 13:07
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@smau-centreon smau-centreon smau-centreon approved these changes

@jeremyjaouen jeremyjaouen jeremyjaouen approved these changes

@callapa callapa Awaiting requested review from callapa

@adr-mo adr-mo Awaiting requested review from adr-mo

Assignees
No one assigned
Labels
area/backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@kduret @jeremyjaouen @smau-centreon