This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
feat(api): endpoint for centreon web upgrade #11307
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
kduret
requested review from
a team,
adr-mo and
TamazC
and removed request for
a team
kduret
changed the title
TamazC
reviewed
Jul 4, 2022
src/Core/Platform/Application/UseCase/UpdateVersions/UpdateVersions.php
Outdated
Show resolved
Hide resolved
src/Core/Platform/Infrastructure/Repository/LegacyReadVersionRepository.php
Outdated
Show resolved
Hide resolved
| class LegacyWriteVersionRepository extends AbstractRepositoryDRB implements WriteVersionRepositoryInterface | ||
| { | ||
| use LoggerTrait; | ||
|
|
There was a problem hiding this comment.
maybe you could define a constant INSTALL_DIR = '''; and use them in different methods ?
| * @param string $filePath | ||
| * @return void | ||
| */ | ||
| private function runSqlFile(string $filePath): void |
There was a problem hiding this comment.
this method has a high cyclomatic complexity and could be refactored
There was a problem hiding this comment.
I've just refactored most of the code by splitting in private methods
src/Core/Platform/Infrastructure/Repository/LegacyWriteVersionRepository.php
Outdated
Show resolved
Hide resolved
src/Core/Platform/Infrastructure/Repository/LegacyWriteVersionRepository.php
Outdated
Show resolved
Hide resolved
src/Core/Platform/Infrastructure/Repository/LegacyWriteVersionRepository.php
Outdated
Show resolved
Hide resolved
src/Core/Platform/Infrastructure/Repository/LegacyWriteVersionRepository.php
Outdated
Show resolved
Hide resolved
src/Core/Platform/Infrastructure/Repository/LegacyWriteVersionRepository.php
Outdated
Show resolved
Hide resolved
jeremyjaouen
reviewed
Jul 5, 2022
src/Core/Platform/Application/Repository/WriteVersionRepositoryInterface.php
Outdated
Show resolved
Hide resolved
jeremyjaouen
reviewed
Jul 5, 2022
src/Core/Platform/Application/UseCase/UpdateVersions/UpdateVersions.php
Outdated
Show resolved
Hide resolved
src/Core/Platform/Application/UseCase/UpdateVersions/UpdateVersions.php
Outdated
Show resolved
Hide resolved
src/Core/Platform/Application/UseCase/UpdateVersions/UpdateVersions.php
Outdated
Show resolved
Hide resolved
src/Core/Platform/Infrastructure/Repository/LegacyReadVersionRepository.php
Outdated
Show resolved
Hide resolved
jeremyjaouen
approved these changes
Jul 5, 2022
kduret
commented
Jul 5, 2022
src/Core/Platform/Application/UseCase/UpdateVersions/UpdateVersions.php
Outdated
Show resolved
Hide resolved
src/Core/Platform/Application/UseCase/UpdateVersions/UpdateVersions.php
Outdated
Show resolved
Hide resolved
src/Core/Platform/Application/UseCase/UpdateVersions/UpdateVersions.php
Outdated
Show resolved
Hide resolved
callapa
reviewed
Jul 5, 2022
src/Core/Platform/Application/UseCase/UpdateVersions/UpdateVersions.php
Outdated
Show resolved
Hide resolved
…sions.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com>
kduret
commented
Jul 5, 2022
src/Core/Platform/Application/UseCase/UpdateVersions/UpdateVersions.php
Outdated
Show resolved
Hide resolved
|
SonarQube Quality Gate
|
adr-mo
approved these changes
Jul 5, 2022
TamazC
approved these changes
Jul 5, 2022
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
add endpoint for centreon web upgrade
this allows to execute all upgrade scripts in a single time via api
next steps :
Fixes MON-12296
Type of change
Target serie