This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
fix(resources): default values correctly sent to ack endpoint #11022
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
adr-mo
requested review from
a team,
jdelpierre,
Jordan91,
a-launois and
TamazC
and removed request for
a team
adr-mo
changed the title
Jordan91
approved these changes
Apr 25, 2022
jdelpierre
reviewed
Apr 25, 2022
|
SonarQube Quality Gate
|
bdauria
approved these changes
Apr 25, 2022
kduret
approved these changes
Apr 25, 2022
adr-mo
added a commit
that referenced
this pull request
Apr 26, 2022
* fix(ack): do not use hardcoded values for persistent and sticky options * Fix naming on persistent prop * Fix naming on sticky option for ACK * Fix unit test for Actions on ACK * Remove timeout in unit test Co-authored-by: Jordan CARO <jcaro@centreon.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
This PR fixes issues with Aknowledgements and default values provided to the endpoint on Resource Status.
Fixes # (issue)
Type of change
Target serie
How this pull request can be tested ?
See Jira ticket
Checklist