Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(perf/curves) sanitize data #10797

Merged
merged 2 commits into from
Feb 25, 2022
Merged

fix(perf/curves) sanitize data #10797

merged 2 commits into from
Feb 25, 2022

Conversation

a-launois
Copy link
Contributor

Description

Sanitize POST datas to preventsecurity vulnerability in monitoring > performance > curves

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 20.10.x
  • 21.04.x
  • 21.10.x
  • 22.04.x (master)

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@a-launois a-launois requested review from a team, callapa, adr-mo, jeremyjaouen, kduret and sc979 and removed request for adr-mo February 25, 2022 09:09
kduret
kduret previously approved these changes Feb 25, 2022
View reviewed changes
sc979
sc979 suggested changes Feb 25, 2022
View reviewed changes
Copy link
Contributor

@sc979 sc979 left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

As selectedCurveTemplates is set line 49, you can also remove the checks line 101 and 111

www/include/views/componentTemplates/componentTemplates.php Outdated Show resolved Hide resolved
@a-launois a-launois requested review from sc979 and kduret February 25, 2022 09:36
@sonarqube-decoration
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
0.0% 0.0% Duplication

@a-launois a-launois merged commit a6662fd into develop Feb 25, 2022
@a-launois a-launois deleted the MON-12502 branch February 25, 2022 15:49
a-launois added a commit that referenced this pull request Feb 25, 2022
@a-launois
fix(perf/curves) sanitize data (#10797)
5f612ec 
* fix(perf/curves) sanitize  data

* apply suggestion
a-launois added a commit that referenced this pull request Feb 25, 2022
@a-launois
fix(perf/curves) sanitize data (#10797)
44bed7f 
* fix(perf/curves) sanitize  data

* apply suggestion
a-launois added a commit that referenced this pull request Feb 25, 2022
@a-launois
fix(perf/curves) sanitize data (#10797)
fce46cf 
* fix(perf/curves) sanitize  data

* apply suggestion
a-launois added a commit that referenced this pull request Mar 4, 2022
@a-launois
fix(perf/curves) sanitize data (#10797)
d41dde2 
* fix(perf/curves) sanitize  data

* apply suggestion
a-launois added a commit that referenced this pull request Mar 4, 2022
@a-launois
fix(perf/curves) sanitize data (#10797)
2c5c41c 
* fix(perf/curves) sanitize  data

* apply suggestion
a-launois added a commit that referenced this pull request Mar 4, 2022
@a-launois
fix(perf/curves) sanitize data (#10797)
a22dce2 
* fix(perf/curves) sanitize  data

* apply suggestion
a-launois added a commit that referenced this pull request Mar 4, 2022
@a-launois
fix(perf/curves) sanitize data (#10797)
ab3b9a7 
* fix(perf/curves) sanitize  data

* apply suggestion
tuntoja pushed a commit that referenced this pull request Mar 17, 2022
@a-launois @tuntoja
fix(perf/curves) sanitize data (#10797)
15a5f2f 
* fix(perf/curves) sanitize  data

* apply suggestion
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@sc979 sc979 sc979 approved these changes

@kduret kduret kduret approved these changes

@callapa callapa Awaiting requested review from callapa

@jeremyjaouen jeremyjaouen Awaiting requested review from jeremyjaouen

Assignees
No one assigned
Labels
area/backend
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@a-launois @kduret @sc979