Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

fix(secu): sanitize ACL group inputs #10789

Merged
merged 10 commits into from
Feb 25, 2022
Merged

fix(secu): sanitize ACL group inputs #10789

merged 10 commits into from
Feb 25, 2022

Conversation

sc979
Copy link
Contributor

@sc979 sc979 commented Feb 24, 2022

Description

sanitize inputs used in ACL group page and form
bindvalues when required

Fixes # (none)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 20.10.x
  • 21.04.x
  • 21.10.x
  • 22.04.x (master)

@sc979 sc979 requested review from a team, callapa, a-launois and kduret and removed request for callapa February 24, 2022 11:35
@sc979 @a-launois
Update www/include/options/accessLists/groupsACL/listGroupConfig.php
ed2b135 
Co-authored-by: alaunois <alaunois@centreon.com>
a-launois
a-launois previously approved these changes Feb 24, 2022
View reviewed changes
@sc979 @kduret
fix(secu): sanitize ACL group enabling action (#10791)
f2c9312 
* fix(secu): sanitize ACL group disabling action

* Update www/include/options/accessLists/groupsACL/DB-Func.php

Co-authored-by: Kevin Duret <kduret@centreon.com>

* style

* fix(secu): sanitize ACL group disabling action (#10794)

* fix(secu): sanitize ACL group disabling action

* fix(secu): sanitize ACL group delete action (#10795)

Co-authored-by: Kevin Duret <kduret@centreon.com>
a-launois
a-launois previously approved these changes Feb 24, 2022
View reviewed changes
sc979 and others added 4 commits February 24, 2022 18:10
@sc979 @kduret
Update www/include/options/accessLists/groupsACL/groupsConfig.php
9912e4f 
Co-authored-by: Kevin Duret <kduret@centreon.com>
@sc979 @kduret
Update www/include/options/accessLists/groupsACL/groupsConfig.php
855e454 
Co-authored-by: Kevin Duret <kduret@centreon.com>
@sc979 @kduret
Update www/include/options/accessLists/groupsACL/groupsConfig.php
bff2250 
Co-authored-by: Kevin Duret <kduret@centreon.com>
@sc979
fix TA
41f89ed
@sonarqube-decoration
Copy link

SonarQube Quality Gate

Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell C 25 Code Smells

No Coverage information No Coverage information
16.4% 16.4% Duplication

@sc979 sc979 requested review from a-launois and kduret February 24, 2022 20:16
@sc979 sc979 merged commit f1e49e5 into develop Feb 25, 2022
@sc979 sc979 deleted the MON-12501 branch February 25, 2022 08:48
sc979 added a commit that referenced this pull request Feb 25, 2022
@sc979
fix(secu): sanitize ACL group inputs (#10789)(#10791)(#10794)&(#10795)
2ce7e11
sc979 added a commit that referenced this pull request Feb 25, 2022
@sc979
fix(secu): sanitize ACL group inputs (#10789)(#10791)(#10794)&(#10795)
21624f0
sc979 added a commit that referenced this pull request Feb 25, 2022
@sc979
fix(secu): sanitize ACL group inputs (#10789)(#10791)(#10794)&(#10795)
7f54682
sc979 added a commit that referenced this pull request Feb 25, 2022
@sc979
fix(secu): sanitize ACL group inputs (#10789)(#10791)(#10794)&(#10795)
93c48a3
sc979 added a commit that referenced this pull request Feb 25, 2022
@sc979
fix(secu): sanitize ACL group inputs (#10789)(#10791)(#10794)&(#10795)
e1481fd
sc979 added a commit that referenced this pull request Feb 25, 2022
@sc979
fix(secu): sanitize ACL group inputs (#10789)(#10791)(#10794)&(#10795)
997927a
sc979 added a commit that referenced this pull request Feb 25, 2022
@sc979
fix(secu): sanitize ACL group inputs (#10789)(#10791)(#10794)&(#10795)
b2ce89d
tuntoja pushed a commit that referenced this pull request Mar 17, 2022
@sc979 @tuntoja
fix(secu): sanitize ACL group inputs (#10789)(#10791)(#10794)&(#10795)
3c43132
sc979 added a commit that referenced this pull request Mar 21, 2022
@sc979
Need QA: "fix(secu): sanitize ACL group inputs (#10789)(#10791)(#10794)…
a995dcc 
…&(#10795)"

This reverts commit f1e49e5.
sc979 added a commit that referenced this pull request Mar 25, 2022
@sc979
fix(secu): sanitize ACL group inputs (#10789)(#10791)(#10794)&(#10795)
6424008
sc979 added a commit that referenced this pull request Mar 25, 2022
@sc979
fix(secu): sanitize ACL group inputs (#10789)(#10791)(#10794)&(#10795)
ebeb5d1
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@a-launois a-launois a-launois approved these changes

@kduret kduret kduret approved these changes

Assignees
No one assigned
Labels
None yet
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
3 participants
@sc979 @kduret @a-launois