Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

enh(resource): display only comments not deleted for ACK and DT #10582

Merged
merged 3 commits into from
Jan 21, 2022

Conversation

adr-mo
Copy link
Contributor

@adr-mo adr-mo commented Jan 20, 2022

This PR intends to use the comment stored in the table comments instead of the comment attached to the acknowledgements / downtimes tables.

This will ensure that if a comment has been deleted through the page Monitoring -> Downtimes -> Comments then in Resource Status this comment will no longer appear in the Resource Detail of listing state tooltip

/!\ Encountered phpstan et phpcs errors were also fixed on files edited

Fixes # (issue)

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 20.10.x
  • 21.04.x
  • 21.10.x
  • 22.04.x (master)

How this pull request can be tested ?

See Jira for details

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@adr-mo adr-mo requested review from a team, callapa and kduret January 20, 2022 15:45
@adr-mo adr-mo changed the title Mon 11125 comments cannot be deleted enh(resource): display only comments not deleted for ACK and DT Jan 20, 2022
@sonarqube-decoration
Copy link

@adr-mo adr-mo merged commit 94e3553 into develop Jan 21, 2022
@adr-mo adr-mo deleted the MON-11125-comments-cannot-be-deleted branch January 21, 2022 12:53
adr-mo added a commit that referenced this pull request Jan 21, 2022
* fix(comments): use comment data from comments table

* phpstan: fix encountered errors

* phpcs: fix encountered errors
adr-mo added a commit that referenced this pull request Jan 21, 2022
* fix(comments): use comment data from comments table

* phpstan: fix encountered errors

* phpcs: fix encountered errors
adr-mo added a commit that referenced this pull request Jan 27, 2022
* fix(comments): use comment data from comments table

* phpstan: fix encountered errors

* phpcs: fix encountered errors
adr-mo added a commit that referenced this pull request Jan 27, 2022
* fix(comments): use comment data from comments table

* phpstan: fix encountered errors

* phpcs: fix encountered errors
adr-mo added a commit that referenced this pull request Jan 27, 2022
* fix(comments): use comment data from comments table

* phpstan: fix encountered errors

* phpcs: fix encountered errors
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants