Skip to content
This repository has been archived by the owner on Dec 13, 2022. It is now read-only.

enh(ci): Fix reference build used for issue recording #10207

Merged
merged 2 commits into from
Sep 28, 2021
Merged

enh(ci): Fix reference build used for issue recording #10207

merged 2 commits into from
Sep 28, 2021

Conversation

zguennoune02
Copy link
Contributor

Description

In order to avoid false positive issue recording, we use now the maintenance branch as reference branch.

Type of change

  • Patch fixing an issue (non-breaking change)
  • New functionality (non-breaking change)
  • Breaking change (patch or feature) that might cause side effects breaking part of the Software
  • Updating documentation (missing information, typo...)

Target serie

  • 20.04.x
  • 20.10.x
  • 21.04.x
  • 21.10.x (master)

How this pull request can be tested ?

Checklist

  • I have followed the coding style guidelines provided by Centreon
  • I have commented my code, especially new classes, functions or any legacy code modified. (docblock)
  • I have commented my code, especially hard-to-understand areas of the PR.
  • I have made corresponding changes to the documentation.
  • I have rebased my development branch on the base branch (master, maintenance).

@zguennoune02 zguennoune02 requested review from kduret, adr-mo, a team, bdauria and Jordan91 September 28, 2021 12:17
@zguennoune02 zguennoune02 changed the base branch from develop to dev-21.04.x September 28, 2021 12:17
@sonarqube-decoration
Copy link

SonarQube Quality Gate:
Quality Gate passed

Bug A 0 Bugs
Vulnerability A 0 Vulnerabilities
Security Hotspot A 0 Security Hotspots
Code Smell A 0 Code Smells

No Coverage information No Coverage information
No Duplication information No Duplication information

@zguennoune02 zguennoune02 merged commit 15fb5b3 into dev-21.04.x Sep 28, 2021
@zguennoune02 zguennoune02 deleted the fix-reference-build branch September 28, 2021 13:20
kduret pushed a commit that referenced this pull request Sep 29, 2021
@zguennoune02 @kduret
enh(ci): Fix reference build used for issue recording (#10207)
7b84b8c 
* use maintenance branch as ref branch for issue recording

* remove the discoverReferenceBuild function
tuntoja pushed a commit that referenced this pull request Sep 29, 2021
@zguennoune02 @tuntoja
enh(ci): Fix reference build used for issue recording (#10207)
d9d6f4d 
* use maintenance branch as ref branch for issue recording

* remove the discoverReferenceBuild function
@sc979 sc979 mentioned this pull request Jan 10, 2022
Closed
8 tasks
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Reviewers

@kduret kduret kduret approved these changes

@adr-mo adr-mo Awaiting requested review from adr-mo

@bdauria bdauria Awaiting requested review from bdauria

@Jordan91 Jordan91 Awaiting requested review from Jordan91

Assignees
No one assigned
Labels
area-ci
Projects
None yet
Milestone
No milestone
Development

Successfully merging this pull request may close these issues.
2 participants
@zguennoune02 @kduret