This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
Mon 10862 allow to do not defined redirect url #10098
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
13 tasks
jeremyjaouen
previously approved these changes
Sep 9, 2021
callapa
suggested changes
Sep 9, 2021
Co-authored-by: Laurent Calvet <lcalvet@centreon.com>
Co-authored-by: Laurent Calvet <lcalvet@centreon.com>
Co-authored-by: Laurent Calvet <lcalvet@centreon.com>
callapa
approved these changes
Sep 9, 2021
a-launois
approved these changes
Sep 9, 2021
|
SonarQube Quality Gate:
|
lpinsivy
added a commit
that referenced
this pull request
Sep 14, 2021
* Add variables for substitutions on openid_connect_redirect_url * Use a default redirect_url if empty * remove tabs, again * Split string into two lines to match centreon coding style * use configured Centreon path as default * reduce line lenght to match Centreon style guides * Improve closing DB cursor * Replace SQL query for oreon_web_path with ssoOptions * split line to comply with style guide * enh(openid): Allow to do not defined redirect URL * Update www/class/centreonAuth.SSO.class.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com> * Update www/class/centreonAuth.SSO.class.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com> * Update www/include/Administration/parameters/general/help.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com> Co-authored-by: Stefan Mayr <stefan@mayr-stefan.de> Co-authored-by: Laurent Calvet <lcalvet@centreon.com>
lpinsivy
added a commit
that referenced
this pull request
Oct 13, 2021
* Add variables for substitutions on openid_connect_redirect_url * Use a default redirect_url if empty * remove tabs, again * Split string into two lines to match centreon coding style * use configured Centreon path as default * reduce line lenght to match Centreon style guides * Improve closing DB cursor * Replace SQL query for oreon_web_path with ssoOptions * split line to comply with style guide * enh(openid): Allow to do not defined redirect URL * Update www/class/centreonAuth.SSO.class.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com> * Update www/class/centreonAuth.SSO.class.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com> * Update www/include/Administration/parameters/general/help.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com> Co-authored-by: Stefan Mayr <stefan@mayr-stefan.de> Co-authored-by: Laurent Calvet <lcalvet@centreon.com>
lpinsivy
added a commit
that referenced
this pull request
Oct 13, 2021
* Add variables for substitutions on openid_connect_redirect_url * Use a default redirect_url if empty * remove tabs, again * Split string into two lines to match centreon coding style * use configured Centreon path as default * reduce line lenght to match Centreon style guides * Improve closing DB cursor * Replace SQL query for oreon_web_path with ssoOptions * split line to comply with style guide * enh(openid): Allow to do not defined redirect URL * Update www/class/centreonAuth.SSO.class.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com> * Update www/class/centreonAuth.SSO.class.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com> * Update www/include/Administration/parameters/general/help.php Co-authored-by: Laurent Calvet <lcalvet@centreon.com> Co-authored-by: Stefan Mayr <stefan@mayr-stefan.de> Co-authored-by: Laurent Calvet <lcalvet@centreon.com>
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Replace #9877
We have two Centreon-UIs using the same database and want to enable OpenID Connect for both instances. Originally both share the same redirect URL. We would like each instance to use the hostname the user connected to.
This patch adds three variables that can be used for substitution in the redirect URL:
{$scheme} for http/https
{$hostname} hostname or ip address the user used to access this Centreon-UI
{$port} port used to access the Centreon-UI
So this can be formed to something like {$scheme}://{$hostname}:{$port}/centreon/index.php
Type of change
Target serie
How this pull request can be tested ?
Use all variables as OpenID Connect Redirect URL or only some of them
Checklist