This repository has been archived by the owner on Dec 13, 2022. It is now read-only.
feat(Resource-status): Add Performance page button #10093
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
Add a new button to access performance page from resource status detail panel, graph section. Refs: MON-10900
jdelpierre
requested review from
a team,
bdauria,
Thebarda,
callapa and
jeremyjaouen
Thebarda
reviewed
Sep 6, 2021
Thebarda
reviewed
Sep 6, 2021
bdauria
reviewed
Sep 7, 2021
@jdelpierre I was wondering if we could try to shift the title to maintain it centered within the panel width? |
Hum, Yes, I test to change the CSS props on the line concerned |
|
I have change CSS props to align the title |
bdauria
approved these changes
Sep 7, 2021
|
SonarQube Quality Gate:
|
jeremyjaouen
approved these changes
Sep 7, 2021
jdelpierre
added a commit
that referenced
this pull request
Sep 7, 2021
* feat(Resource-status): Add Performance page button Add a new button to access performance page from resource status detail panel, graph section. Refs: MON-10900 * change naming of the label variable performance page * replace button to iconButton and add useHistory router * change the label of the link button * Change CSS Props to align the title on graph panel
jdelpierre
added a commit
that referenced
this pull request
Sep 9, 2021
* feat(Resource-status): Add Performance page button Add a new button to access performance page from resource status detail panel, graph section. Refs: MON-10900 * change naming of the label variable performance page * replace button to iconButton and add useHistory router * change the label of the link button * Change CSS Props to align the title on graph panel
jdelpierre
added a commit
that referenced
this pull request
Sep 9, 2021
* feat(Resource-status): Add Performance page button Add a new button to access performance page from resource status detail panel, graph section. Refs: MON-10900 * change naming of the label variable performance page * replace button to iconButton and add useHistory router * change the label of the link button * Change CSS Props to align the title on graph panel
Sign up for free
to subscribe to this conversation on GitHub.
Already have an account?
Sign in.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Add a new button to access performance page from resource status detail panel, graph section.
Refs: MON-10900
Screenshot with the button on the right panel
Type of change
Target serie
How this pull request can be tested ?
Please describe the procedure to verify that the goal of the PR is matched. Provide clear instructions so that it can be correctly tested.
Any relevant details of the configuration to perform the test should be added.
Checklist