FIX: Sanitize and bind Meta Service configuration 22.04.x (#11733)

* sanitize and bind meta service config * applying suggested changes
centreon · Sep 13, 2022 · 2aebf3e · 2aebf3e
1 parent 0df5876
commit 2aebf3e
Showing 1 changed file with 13 additions and 6 deletions.
diff --git a/www/class/centreonMeta.class.php b/www/class/centreonMeta.class.php
@@ -305,20 +305,27 @@ public function insertVirtualService($metaId, $metaName)
             $row = $res->fetchRow();
             $serviceId = $row['service_id'];
             if ($row['display_name'] !== $metaName) {
-                $query = 'UPDATE service SET display_name = "' . $metaName . '" WHERE service_id = ' . $serviceId;
-                $this->db->query($query);
+                $query = 'UPDATE service SET display_name = :display_name WHERE service_id = :service_id';
+                $statement = $this->db->prepare($query);
+                $statement->bindValue(':display_name', $metaName, \PDO::PARAM_STR);
+                $statement->bindValue(':service_id', (int) $serviceId, \PDO::PARAM_INT);
+                $statement->execute();
             }
         } else {
             $query = 'INSERT INTO service (service_description, display_name, service_register) '
                 . 'VALUES '
                 . '("' . $composedName . '", "' . $metaName . '", "2")';
             $this->db->query($query);
             $query = 'INSERT INTO host_service_relation(host_host_id, service_service_id) '
-                . 'VALUES ('
-                . $hostId . ','
-                . '(SELECT service_id FROM service WHERE service_description = "' . $composedName . '" AND service_register = "2" LIMIT 1)'
+                . 'VALUES (:host_id,'
+                . '(SELECT service_id 
+                    FROM service 
+                    WHERE service_description = :service_description AND service_register = "2" LIMIT 1)'
                 . ')';
-            $this->db->query($query);
+            $statement = $this->db->prepare($query);
+            $statement->bindValue(':host_id', (int) $hostId, \PDO::PARAM_INT);
+            $statement->bindValue(':service_description', $composedName, \PDO::PARAM_STR);
+            $statement->execute();
             $res = $this->db->query($queryService);
             if ($res->rowCount()) {
                 $row = $res->fetchRow();