test(acceptance): improve logs of dst downtime acceptance tests

centreon · Jun 20, 2018 · 273f548 · 273f548
1 parent cb404be
commit 273f548
Showing 1 changed file with 10 additions and 9 deletions.
diff --git a/features/bootstrap/DowntimeDSTContext.php b/features/bootstrap/DowntimeDSTContext.php
@@ -323,7 +323,6 @@ public function theDowntimeIsProperlyScheduled()
     {
         $this->spin(
             function ($context) {
-                $scheduled = false;
                 $return = $context->container->execute(
                     "cat /var/log/centreon-engine/centengine.log",
                     'web'
@@ -334,16 +333,16 @@ function ($context) {
                     $output,
                     $matches
                 )) {
-                    $startTimestamp = end($matches[1]);
-                    $endTimestamp = end($matches[2]);
+                    $startTimestamp = $matches[1];
+                    $endTimestamp = $matches[2];
                     $dateStart = new DateTime('now', new \DateTimeZone('Europe/Paris'));
                     $dateStart->setTimestamp($startTimestamp);
                     $dateEnd = new DateTime('now', new \DateTimeZone('Europe/Paris'));
                     $dateEnd->setTimestamp($endTimestamp);
-                    if ($dateStart->format('Y-m-d H:i') == $context->downtimeProperties['expected_start'] &&
-                        $dateEnd->format('Y-m-d H:i') == $context->downtimeProperties['expected_end'] &&
-                        ($endTimestamp - $startTimestamp) == $context->downtimeProperties['expected_duration']) {
-                        $scheduled = true;
+                    if ($dateStart->format('Y-m-d H:i') != $context->downtimeProperties['expected_start'] ||
+                        $dateEnd->format('Y-m-d H:i') != $context->downtimeProperties['expected_end'] ||
+                        ($endTimestamp - $startTimestamp) != $context->downtimeProperties['expected_duration']) {
+                        throw new \Exception('Downtime external command parameters are wrong (start, end or duration)');
                     }
                     $storageDb = $context->getStorageDatabase();
                     $res = $storageDb->query(
@@ -352,11 +351,13 @@ function ($context) {
                         "AND end_time = " . $endTimestamp
                     );
                     if (!$res->fetch()) {
-                        $scheduled = false;
+                        throw new \Exception('Downtime does not exist in storage database');
                     }
+                } else {
+                    throw new \Exception('Downtime external command does not exist in centengine logs');
                 }
 
-                return $scheduled;
+                return true;
             },
             'Downtime is not scheduled',
             10