Skip to content
This repository has been archived by the owner on Nov 7, 2022. It is now read-only.

Fixed Jaeger GRPC exporter #622

Merged

Conversation

owais
Copy link
Contributor

@owais owais commented Sep 5, 2019

The exporter was essentially crashing itself unconditionally

@owais owais requested a review from flands September 5, 2019 17:33
Copy link
Contributor

@flands flands left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@owais owais force-pushed the fix-jaeger-grpc-exporter branch from b275351 to 1148791 Compare September 5, 2019 17:35
Copy link

@bogdandrutu bogdandrutu left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

:) good tests for this.

@owais
Copy link
Contributor Author

owais commented Sep 5, 2019

Travis build is failing for an unrelated reason. Looks like it can't pull in some dependencies. I tried building locally even after wiping all of my Go modules cache and it worked without any issues.

CI error:

go: git.apache.org/thrift.git@v0.0.0-20180902110319-2566ecd5d999: git fetch -f origin refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /home/travis/gopath/pkg/mod/cache/vcs/83dba939f95a790e497d565fc4418400145a1a514f955fa052f662d56e920c3e: exit status 128:

	fatal: unable to access 'https://git.apache.org/thrift.git/': Failed to connect to git.apache.org port 443: Connection timed out

go: error loading module requirements

go install golang.org/x/lint/golint

go: finding git.apache.org/thrift.git v0.0.0-20180902110319-2566ecd5d999

go: git.apache.org/thrift.git@v0.0.0-20180902110319-2566ecd5d999: git fetch -f https://git.apache.org/thrift.git refs/heads/*:refs/heads/* refs/tags/*:refs/tags/* in /home/travis/gopath/pkg/mod/cache/vcs/83dba939f95a790e497d565fc4418400145a1a514f955fa052f662d56e920c3e: exit status 128:

	fatal: unable to access 'https://git.apache.org/thrift.git/': Failed to connect to git.apache.org port 443: Connection timed out

go: error loading module requirements

Makefile:82: recipe for target 'install-tools' failed

make: *** [install-tools] Error 1

The exporter was essentially crashing itself unconditionally
@owais owais force-pushed the fix-jaeger-grpc-exporter branch from 1148791 to 14f4185 Compare September 5, 2019 22:29
@codecov
Copy link

codecov bot commented Sep 5, 2019

Codecov Report

Merging #622 into master will decrease coverage by 0.01%.
The diff coverage is 0%.

Impacted file tree graph

@@            Coverage Diff             @@
##           master     #622      +/-   ##
==========================================
- Coverage   69.35%   69.34%   -0.02%     
==========================================
  Files          93       93              
  Lines        6157     6158       +1     
==========================================
  Hits         4270     4270              
- Misses       1660     1661       +1     
  Partials      227      227
Impacted Files Coverage Δ
...occollector/app/sender/jaeger_proto_grpc_sender.go 0% <0%> (ø) ⬆️

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 372edb9...14f4185. Read the comment docs.

@owais
Copy link
Contributor Author

owais commented Sep 5, 2019

The repo was moved to github. Adding a replace directive fixed the build. https://github.com/census-instrumentation/opencensus-service/pull/622/files#diff-37aff102a57d3d7b797f152915a6dc16R63

@owais owais merged commit fb16513 into census-instrumentation:master Sep 5, 2019
@owais owais deleted the fix-jaeger-grpc-exporter branch September 5, 2019 22:44
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants