-
Notifications
You must be signed in to change notification settings - Fork 63
Fixed Jaeger GRPC exporter #622
Fixed Jaeger GRPC exporter #622
Conversation
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
LGTM
b275351
to
1148791
Compare
There was a problem hiding this comment.
Choose a reason for hiding this comment
The reason will be displayed to describe this comment to others. Learn more.
:) good tests for this.
Travis build is failing for an unrelated reason. Looks like it can't pull in some dependencies. I tried building locally even after wiping all of my Go modules cache and it worked without any issues. CI error:
|
The exporter was essentially crashing itself unconditionally
1148791
to
14f4185
Compare
Codecov Report
@@ Coverage Diff @@
## master #622 +/- ##
==========================================
- Coverage 69.35% 69.34% -0.02%
==========================================
Files 93 93
Lines 6157 6158 +1
==========================================
Hits 4270 4270
- Misses 1660 1661 +1
Partials 227 227
Continue to review full report at Codecov.
|
The repo was moved to github. Adding a replace directive fixed the build. https://github.com/census-instrumentation/opencensus-service/pull/622/files#diff-37aff102a57d3d7b797f152915a6dc16R63 |
The exporter was essentially crashing itself unconditionally