Jaeger grpc exporter #433
Jaeger grpc exporter #433
Conversation
|
Nice! |
|
I think unfortunately you will have a not-so-clean merge on rebasing with master again, but everything pre rebase LGTM. Once you rebase I can go over quickly one last time :) Thanks for the contribution! |
annanay25
force-pushed
the
jaeger-grpc-exporter
branch
from
2e02e83 to
386acaa
Compare
|
@sjkaris I've rebased and pushed changes, I hope these were the only changes required. Will check again after you review :) |
annanay25
force-pushed
the
jaeger-grpc-exporter
branch
2 times, most recently
from
6b24c41 to
9454050
Compare
It was also necessary to fix the time translation to ensure that it was in UTC.
annanay25
force-pushed
the
jaeger-grpc-exporter
branch
from
d68f00f to
b56d0ef
Compare
|
So there's good news and bad news. 👍 The good news is that everyone that needs to sign a CLA (the pull request submitter and all commit authors) have done so. Everything is all good there. 😕 The bad news is that it appears that one or more commits were authored or co-authored by someone other than the pull request submitter. We need to confirm that all authors are ok with their commits being contributed to this project. Please have them confirm that here in the pull request. Note to project maintainer: This is a terminal state, meaning the ℹ️ Googlers: Go here for more info. |
|
A Googler has manually verified that the CLAs look good. (Googler, please make sure the reason for overriding the CLA status is clearly documented in these comments.) ℹ️ Googlers: Go here for more info. |
| // NewJaegerProtoGRPCSender returns a new GRPC-backend span sender. | ||
| // The collector endpoint should be of the form "hostname:14250". | ||
| func NewJaegerProtoGRPCSender(collectorEndpoint string, zlogger *zap.Logger) *JaegerProtoGRPCSender { | ||
| client, err := grpc.Dial(collectorEndpoint, grpc.WithInsecure()) |
There was a problem hiding this comment.
FYI jaeger-collector supports TLS connections now: jaegertracing/jaeger#1311
| // The collector endpoint should be of the form "hostname:14250". | ||
| func NewJaegerProtoGRPCSender(collectorEndpoint string, zlogger *zap.Logger) *JaegerProtoGRPCSender { | ||
| client, err := grpc.Dial(collectorEndpoint, grpc.WithInsecure()) | ||
| zlogger.Fatal("Failed to dail grpc connection", zap.Error(err)) |
|
Thanks for the reviews @benley! |
|
Thanks for implementing this feature, @annanay25! |
Resolves #279
Added oc-proto to jaeger-proto translation, and jaeger-grpc sender.