Fix stackdriver tests #921
Merged
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
aabmass
force-pushed
the
fix-sd-tests-905
branch
from
15da7f5
to
0047bcd
Compare
aabmass
requested review from
c24t,
hectorhdzg,
lzchen,
reyang,
songy23 and
a team
as code owners
aabmass
force-pushed
the
fix-sd-tests-905
branch
from
0047bcd
to
f9ae95c
Compare
c24t
approved these changes
Jun 24, 2020
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Fixes #905. Reset the stackdriver tests to commit fce9d22. The
google-authpackage upgraded the version of rsa, but rsa 4.1 drops python 2 and 3.4 support. Solution is to pin thersapackage version for unsupported python versions.Although
google-authhas dropped 2.7, it still supports 3.4 so I opened an issue with them googleapis/google-auth-library-python#548