Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Add mean property for distribution value #919

Merged
merged 5 commits into from
Jun 25, 2020
Merged

Add mean property for distribution value #919

merged 5 commits into from
Jun 25, 2020

Conversation

marianhromiak
Copy link
Contributor

This PR only add missing "mean" property which is missing in SD distribution value.

@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it! and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@c24t
Copy link
Member

c24t commented Jun 23, 2020

Hey @marianhromiak, thanks for the PR. The change LGTM, I changed some tests in dc3a013 such that they'll fail without this change.

@lzchen (and cc @aabmass) I see that you removed these tests in #905, we'll need them back to merge this PR.

@c24t
Copy link
Member

c24t commented Jun 23, 2020

@marianhromiak please sign the CLA.

@lzchen
Copy link
Contributor

lzchen commented Jun 24, 2020

@c24t
stackdriver tests were failing builds for some reason. I believe those have to be resolved first before merging the PR.

@aabmass
Copy link
Member

aabmass commented Jun 24, 2020

Sorry, I'll look into those tests first thing tomorrow!

Copy link
Member

@aabmass aabmass left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

Copy link
Contributor

@lzchen lzchen left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@lzchen lzchen merged commit 1846676 into census-instrumentation:master Jun 25, 2020
@lzchen lzchen mentioned this pull request Jun 29, 2020
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

5 participants