Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Check that url_rule is not None before dereferencing property #781

Merged
merged 1 commit into from
Sep 3, 2019

Conversation

jtbeach
Copy link
Contributor

@jtbeach jtbeach commented Sep 2, 2019

Fixes #777

@jtbeach jtbeach requested review from c24t, reyang, songy23 and a team as code owners September 2, 2019 01:12
@googlebot
Copy link

Thanks for your pull request. It looks like this may be your first contribution to a Google open source project (if not, look below for help). Before we can look at your pull request, you'll need to sign a Contributor License Agreement (CLA).

📝 Please visit https://cla.developers.google.com/ to sign.

Once you've signed (or fixed any issues), please reply here with @googlebot I signed it!) and we'll verify it.


What to do if you already signed the CLA

Individual signers
Corporate signers

ℹ️ Googlers: Go here for more info.

@jtbeach
Copy link
Contributor Author

jtbeach commented Sep 2, 2019

@googlebot I signed it!

@googlebot
Copy link

CLAs look good, thanks!

ℹ️ Googlers: Go here for more info.

@olance
Copy link
Contributor

olance commented Sep 2, 2019

@jtbeach you should improve the tests I had provided for the HTTP_ROUTE attribute, to add one that specifically tests a non-existing route.

Happy to help if needed!

@jtbeach
Copy link
Contributor Author

jtbeach commented Sep 3, 2019

@olance @reyang I think this is now ready for review

Copy link
Contributor

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

LGTM

@reyang reyang merged commit 2457a87 into census-instrumentation:master Sep 3, 2019
@reyang
Copy link
Contributor

reyang commented Sep 3, 2019

Thanks @jtbeach and @olance!

@jtbeach
Copy link
Contributor Author

jtbeach commented Sep 25, 2019

@reyang Any idea when a release will be made with this fix?

@lzchen
Copy link
Contributor

lzchen commented Oct 1, 2019

@jtbeach
https://github.com/census-instrumentation/opencensus-python/releases/tag/v0.7.5

Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Flask middleware raises AttributeError for 404 routes
5 participants