Skip to content
New issue

Have a question about this project? Sign up for a free GitHub account to open an issue and contact its maintainers and the community.

By clicking “Sign up for GitHub”, you agree to our terms of service and privacy statement. We’ll occasionally send you account related emails.

Already on GitHub? Sign in to your account

Standard Metrics - Incoming Requests Execution Time #773

Merged
merged 8 commits into from
Aug 27, 2019

Conversation

lzchen
Copy link
Contributor

@lzchen lzchen commented Aug 23, 2019

Part of [#695]. Standard metric for incoming requests Average Execution Time in milliseconds. Incoming requests are under "http_requests".
Track incoming requests to an HTTPServer on the application. Currently, incoming requests are shown "performanceCounters" table in Application Insights.

This is the last standard metric as part of the effort to achieve feature parity with Application Insights SDK in other languages.

image

@lzchen lzchen requested review from reyang and removed request for reyang August 23, 2019 22:03
Copy link
Contributor

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Need to make sure there is no race condition.

Copy link
Contributor

@reyang reyang left a comment

Choose a reason for hiding this comment

The reason will be displayed to describe this comment to others. Learn more.

Looks good in general, I've left some comments regarding the definitions of "average execution time".

@lzchen lzchen merged commit 8e582cb into census-instrumentation:master Aug 27, 2019
Sign up for free to join this conversation on GitHub. Already have an account? Sign in to comment
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

3 participants