Skip to content
This repository has been archived by the owner on Oct 3, 2023. It is now read-only.

Map http attributes to the stackdriver format #652

Merged
merged 2 commits into from
Sep 17, 2019

Conversation

mayurkale22
Copy link
Member

Resolves #651

These changes have all been tested locally against a real stackdriver instance and been confirmed to be working.

Earlier Now
Screen Shot 2019-09-16 at 11 49 58 AM Screen Shot 2019-09-16 at 11 50 27 AM

@mayurkale22
Copy link
Member Author

/cc @loneparadox Please review

@codecov-io
Copy link

Codecov Report

Merging #652 into master will increase coverage by 0.2%.
The diff coverage is n/a.

Impacted file tree graph

@@            Coverage Diff            @@
##           master     #652     +/-   ##
=========================================
+ Coverage   95.24%   95.45%   +0.2%     
=========================================
  Files         147      148      +1     
  Lines       10361    10729    +368     
  Branches      792      803     +11     
=========================================
+ Hits         9868    10241    +373     
+ Misses        493      488      -5
Impacted Files Coverage Δ
src/resource-labels.ts 100% <0%> (ø) ⬆️
test/test-stackdriver-cloudtrace-utils.ts 100% <0%> (ø) ⬆️
test/test-prometheus-stats.ts 100% <0%> (ø) ⬆️
src/validators.ts 100% <0%> (ø) ⬆️
src/detect-resource.ts 100% <0%> (ø) ⬆️
src/constants.ts 100% <0%> (ø)
src/stackdriver-cloudtrace-utils.ts 96.66% <0%> (+0.05%) ⬆️
src/tracecontext-format.ts 95.74% <0%> (+4.83%) ⬆️
test/test-detect-resource.ts 99% <0%> (+5.56%) ⬆️
test/test-tracecontext-format.ts 96.62% <0%> (+7.15%) ⬆️
... and 1 more

Continue to review full report at Codecov.

Legend - Click here to learn more
Δ = absolute <relative> (impact), ø = not affected, ? = missing data
Powered by Codecov. Last update 77ecbf0...5b8b4a5. Read the comment docs.

@mayurkale22 mayurkale22 merged commit 98d0442 into census-instrumentation:master Sep 17, 2019
@mayurkale22 mayurkale22 deleted the issue#651 branch September 17, 2019 15:23
Sign up for free to subscribe to this conversation on GitHub. Already have an account? Sign in.
Labels
Projects
None yet
Development

Successfully merging this pull request may close these issues.

Stackdriver Exporter does not seem to export the field as expected by stackdriver
5 participants