This repository has been archived by the owner on Oct 3, 2023. It is now read-only.
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
We shipped our APM with the
@opencensus/core
package. We didn't enable the tracer by default but since when required, it will require thecontinuation-local-storage
which will apply patches automatically. So even if you useasync_hooks
, you will have the patchs from the userland CLS.I believe it's safe to change this behavior since it will work the same way.
I would like to raise also the fact that we could only require both CLS implementation when the tracing is enabled to decrease the performance impact when not enabled.
If you are interested, here are the different complaints from users: keymetrics/pm2-io-apm#235